chore: migrate from npm to pnpm#109
Open
loudsheep wants to merge 1 commit into
Open
Conversation
Member
loudsheep
commented
May 26, 2026
- Replace package-lock.json with pnpm-lock.yaml
- Add .npmrc with shamefully-hoist=true for NestJS compatibility
- Add packageManager field and pnpm.onlyBuiltDependencies to package.json
- Update CI workflow to use pnpm/action-setup and pnpm commands
- Replace package-lock.json with pnpm-lock.yaml - Add .npmrc with shamefully-hoist=true for NestJS compatibility - Add packageManager field and pnpm.onlyBuiltDependencies to package.json - Update CI workflow to use pnpm/action-setup and pnpm commands
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s Node.js dependency management and CI pipeline from npm to pnpm to improve install performance and lockfile consistency across environments.
Changes:
- Add
packageManagerand pnpm configuration (pnpm.onlyBuiltDependencies) topackage.json. - Add
.npmrcwithshamefully-hoist=trueto support NestJS/module resolution expectations. - Update GitHub Actions CI workflow to install/cache dependencies with pnpm and run pnpm-based commands.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
package.json |
Pins pnpm via packageManager and adds pnpm-specific configuration. |
.npmrc |
Enables shamefully-hoist for pnpm installs. |
.github/workflows/ci.yml |
Switches dependency install and script execution in CI from npm to pnpm. |
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:52
- This uses
npx prisma ...even though dependencies are installed with pnpm;npxcan fall back to downloading packages and ignores pnpm's lockfile guarantees. Preferpnpm exec prisma generate(or apnpm runscript) to ensure the Prisma CLI version comes from the lockfile.
- name: Generate Prisma Client
run: npx prisma generate
if: always()
.github/workflows/ci.yml:66
- Same concern as above:
npx prisma migrate deploycan bypass the pnpm lockfile if it falls back to downloading. Preferpnpm exec prisma migrate deployso CI always runs the Prisma CLI version installed by pnpm.
- name: Apply Prisma migrations
run: npx prisma migrate deploy
if: always()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 10 |
|
|
||
| - name: Check commit name | ||
| if: github.event_name == 'pull_request' | ||
| run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.