test: automatic CRUD forms#49
Merged
Merged
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
kguzek
force-pushed
the
test/crud-forms
branch
2 times, most recently
from
July 26, 2025 00:25
38a1955 to
944a880
Compare
Rei-x
previously approved these changes
Aug 20, 2025
Rei-x
left a comment
Rei-x
left a comment
Member
There was a problem hiding this comment.
bardzo rozległe testy, fajnie, że się tak postarałeś - najbardziej zwróć uwagę, żeby nie testować implementacji tylko rzeczy widoczne dla użytkownika
Comment on lines
+12
to
+14
| env: | ||
| TEST_USER_EMAIL: ${{ secrets.TEST_USER_EMAIL }} | ||
| TEST_USER_PASSWORD: ${{ secrets.TEST_USER_PASSWORD }} |
Member
There was a problem hiding this comment.
ja akurat wolę mieć unikalne credentiale na każdy test - zwłaszcza jeśli testujesz tutaj produkcyjne api bo możesz mieć kolizje jak dwa testy się odpalą na raz
| resource: Resource, | ||
| options: SortOrFilter, | ||
| ): Promise<void>; | ||
| export async function setAbstractResourceListFilters( |
Member
There was a problem hiding this comment.
spoko helpery (ale widzę, że typescript wjechał mocno) 😭
ogólnie do takich abstrakcji zalecam Page Object Model - to jest standardowa praktyka w playwrighcie:
https://playwright.dev/docs/pom
Rei-x
reviewed
Aug 20, 2025
kguzek
force-pushed
the
test/crud-forms
branch
4 times, most recently
from
August 25, 2025 02:29
2165a34 to
1c8d5bb
Compare
kguzek
added a commit
that referenced
this pull request
Aug 25, 2025
+ accessible labels for buttons without text + modularize github actions + update types to more closely reflect API responses + add more information on bad responses
kguzek
force-pushed
the
test/crud-forms
branch
2 times, most recently
from
August 25, 2025 04:56
b740716 to
431d6f6
Compare
kguzek
force-pushed
the
test/crud-forms
branch
from
September 9, 2025 22:46
431d6f6 to
c1e1cbc
Compare
kguzek
force-pushed
the
test/crud-forms
branch
from
September 9, 2025 23:45
a3b6023 to
2c272fa
Compare
kguzek
added a commit
that referenced
this pull request
Sep 13, 2025
+ accessible labels for buttons without text + modularize github actions + update types to more closely reflect API responses + add more information on bad responses
kguzek
force-pushed
the
feat/automatic-crud
branch
from
September 13, 2025 00:12
55c3dca to
161cbcb
Compare
kguzek
added a commit
that referenced
this pull request
Sep 13, 2025
+ accessible labels for buttons without text + modularize github actions + update types to more closely reflect API responses + add more information on bad responses
kguzek
force-pushed
the
feat/automatic-crud
branch
from
September 13, 2025 00:16
161cbcb to
3790729
Compare
kguzek
force-pushed
the
test/crud-forms
branch
from
October 26, 2025 16:41
955ee61 to
ed6c99b
Compare
react testing library cannot access minimal tiptap's RTE as it is not a semantic textarea element. this should be tested using e2e tests
kguzek
force-pushed
the
test/crud-forms
branch
from
October 26, 2025 17:45
7c89983 to
852c40f
Compare
+ also update the environment variable names to match usage
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kguzek
force-pushed
the
test/crud-forms
branch
4 times, most recently
from
October 26, 2025 21:41
3c841de to
d3cc8a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testy do tworzenia, edytownia, usuwania i wyświetlania zasobów -- jednostkowe dla artykułów i integracyjne dla organizacji studenckich
są też szybkie testy integracyjne dla logowania i wylogowywania (logowanie nie działa na webkicie więc dlatego testy są tylko dla chrome i firefoxa XD)
Important
Add unit and e2e tests for CRUD operations and authentication, configure Playwright, and update CI workflow.
guide-articles-create-page.test.tsx.auth-flow.spec.tsand student organizations CRUD instudent-organizations.spec.ts.helpers.ts..github/workflows/ci.ymlto run Playwright tests and upload reports.playwright.config.ts.vitest.config.mtsto exclude e2e tests from Vitest.@playwright/testanddotenvtopackage.jsondevDependencies.LoginFormtoform.tsxand updatepage.tsxto use it.This description was created by
for 49b7781. You can customize this summary. It will automatically update as commits are pushed.