Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes type hints throughout the codebase by replacing incorrect parentheses-based type syntax with proper square bracket syntax, and updates docstrings to follow consistent NumPy-style formatting.
Changes:
- Fixed type hint syntax from
Dict(str, List)toDict[str, List]and similar corrections across multiple files - Standardized docstrings to NumPy format with proper Parameters/Returns sections
- Corrected spelling errors in comments and docstrings
- Updated version number from 1.2.5 to 1.2.6
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| somadata/tools/adat_concatenation.py | Fixed return type hints from Dict(str, List) to Dict[str, List] |
| somadata/io/adat/file.py | Updated type hints and docstrings, corrected example usage from Adat.from_file to read_adat |
| somadata/data/lift.py | Added comprehensive docstrings, fixed spelling of "across", and corrected misplaced docstring |
| somadata/base/adat_meta_helpers.py | Fixed Union type hints throughout, corrected parameter names in examples, removed duplicate example, and fixed missing closing quote |
| somadata/base/adat_math_helpers.py | Enhanced docstring with Parameters/Returns sections and fixed spelling of "enter" |
| pyproject.toml | Bumped version from 1.2.5 to 1.2.6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.