Update preProcessAdat() to improve clarity #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed the `filter.qc` parameter name to `filter.rowcheck` to be more intuitive to users - removed language that discusses implication of ColCheck SeqIds not being removed from preProcessAdat() output - updated stat workflow articles with clearer messaging comments around preProcessAdat() - updated two-group and three-group analysis workflow articles to set center.scale = FALSE in preProcessAdat() to align with guidance to users for univariate analysis
scheidec
force-pushed
the
preprocess-filter-rowcheck
branch
from
6bd7b8b to
4669f73
Compare
- for backward compatibility, `filter.qc` is still accepted in preProcessAdat(), but will generate a deprecation warning and will be removed in a future version - users should update their code to use `filter.rowcheck` instead
scheidec
force-pushed
the
preprocess-filter-rowcheck
branch
from
4669f73 to
53f25ed
Compare
alexatSL
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filter.qcparameter name tofilter.rowcheckto be more intuitive to userspreProcessAdat()outputcenter.scale = FALSEinpreProcessAdat()to align with guidance to users for univariate analysis