fix: repair the broken main build (ShieldAlert import, legal screens)#1039
Open
Anexus5919 wants to merge 1 commit into
Open
fix: repair the broken main build (ShieldAlert import, legal screens)#1039Anexus5919 wants to merge 1 commit into
Anexus5919 wants to merge 1 commit into
Conversation
The build has been failing on main for every PR. Two causes: WorkoutScreen.tsx renders <ShieldAlert /> but never imported it, so the lint step fails with react/jsx-no-undef. Add ShieldAlert to the lucide-react import. App.tsx compares currentScreen against "privacy" and "terms&conditions" and renders both screens, but neither is in the Screen union, so tsc fails with TS2367. Add both to the union and to SCREEN_TRANSITIONS, and allow them from welcome (WelcomeScreen navigates to them).
|
@Anexus5919 is attempting to deploy a commit to the somiljain2024-4175's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@Somil450 Kindly have a review on this pr. Thanks! |
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
Fixes #1038
📝 Description
The frontend build is currently broken on
main(CI has failed on the last several commits, and every open PR inherits the failure). Two independent regressions are responsible.🔹 What has been changed?
ShieldAlertimport:WorkoutScreen.tsxrenders<ShieldAlert />but never imported it, so the lint step fails withreact/jsx-no-undef. AddedShieldAlertto the existinglucide-reactimport.App.tsxcomparescurrentScreenagainst"privacy"and"terms&conditions"and renders both screens (andWelcomeScreennavigates to them), but neither was a member of theScreenunion, sotscfailed withTS2367. Added both to theScreenunion, added theirSCREEN_TRANSITIONSentries (["welcome"]), and allowed them as transitions fromwelcome.🔹 Why are these changes needed?
currentScreento string literals outside its type breaks the type-check. Together they fail CI for every branch. These two small fixes makemainbuild and lint cleanly again so open PRs can go green.🛠️ Type of Change
🧪 Testing
✅ Tests Performed
npx tsc --noEmitis clean (with dependencies installed, matching CI); the previously failingTS2367errors onApp.tsxare gone.npx eslinton the changed files is clean; thereact/jsx-no-undeferror onWorkoutScreen.tsx:1035is resolved.welcomecan transition toprivacy/terms&conditionsand each returns towelcome.🌐 Browsers Tested
Not applicable (build/type fix; no runtime behavior change beyond the legal-screen navigation already present).
📷 Screenshots / Demo (if applicable)
Not applicable.
📋 Checklist
💬 Additional Notes
Branched from
upstream/main; merges cleanly. This unblocks CI for the other open PRs, which are currently red only because of thismainbreakage (a Markdown-only PR fails at the same lint step).