foo

Author: SonSang

.github/workflows/alarm.yml

@@ -140,17 +140,18 @@ jobs:
           def fmt_num(v):
               if v is None or (isinstance(v,float) and math.isnan(v)): return "—"
               try:
-                  if abs(v) >= 1000: return f"{v:,.0f}"
-                  return f"{v:.2f}" if isinstance(v,float) and not v.is_integer() else f"{int(v)}"
+                  if isinstance(v, float) and not v.is_integer():
+                      return f"{v:.2f}"
+                  return f"{int(v):,}"
               except Exception:
                   return str(v)
 
           def fmt_pct(v, highlight=False):
-              if v is None: return "—"
+              if v is None or (isinstance(v,float) and math.isnan(v)): return "—"
               s = f"{v:+.2f}%"
               return f"**{s}**" if highlight else s
 
-          # ----- read run params -----
+          # ----- thresholds -----
           tol_rt = float(os.environ.get("RUNTIME_REGRESSION_TOLERANCE_PCT","10"))
           tol_ct = float(os.environ.get("COMPILE_REGRESSION_TOLERANCE_PCT","10"))
           MAX_REVISIONS = int(os.environ.get("MAX_REVISIONS","5"))
@@ -159,7 +160,6 @@ jobs:
           # ----- load artifact (current results) -----
           artifacts_path = os.path.abspath(os.environ.get("ARTIFACTS_DIR", "./artifacts"))
           if not os.path.exists(artifacts_path):
-              # no data → no comment/check body
               open(os.environ.get("PR_COMMENT_PATH","pr_comment.md"),"w").close()
               open(os.environ.get("CHECK_BODY_PATH","check_output.md"),"w").close()
               sys.exit(0)
@@ -238,57 +238,75 @@ jobs:
                       vals.append(float(v))
               return stats.mean(vals) if vals else None
 
-          # ----- build table rows for ALL benchmarks -----
-          rows = []
+          # ----- build TWO tables -----
+          rows_rt = []
+          rows_ct = []
           reg_found = False
           for bid in sorted(current_bm.keys()):
-              cur_rt = current_bm[bid].get("runtime_fps")
-              cur_ct = current_bm[bid].get("compile_time")
+              cur_rt = 0 #current_bm[bid].get("runtime_fps")
+              cur_ct = 0 #current_bm[bid].get("compile_time")
               base_rt = mean_of("runtime_fps", bid)
               base_ct = mean_of("compile_time", bid)
 
               d_rt = ((cur_rt - base_rt)/base_rt*100.0) if (base_rt and isinstance(cur_rt,(int,float))) else None
               d_ct = ((cur_ct - base_ct)/base_ct*100.0) if (base_ct and isinstance(cur_ct,(int,float))) else None
 
-              is_reg = (d_rt is not None and d_rt < -tol_rt) or (d_ct is not None and d_ct > tol_ct)
-              reg_found = reg_found or is_reg
+              is_rt_reg = (d_rt is not None and d_rt < -tol_rt)
+              is_ct_reg = (d_ct is not None and d_ct > tol_ct)
+              reg_found = reg_found or is_rt_reg or is_ct_reg
 
-              stat = "🔴" if is_reg else "✅"
-              delta_rt_cell = fmt_pct(d_rt, highlight=is_reg and d_rt is not None and d_rt < -tol_rt)
-              delta_ct_cell = fmt_pct(d_ct, highlight=is_reg and d_ct is not None and d_ct > tol_ct)
+              stat_rt = "🔴" if is_rt_reg else ("ℹ️" if base_rt is None else "✅")
+              stat_ct = "🔴" if is_ct_reg else ("ℹ️" if base_ct is None else "✅")
 
-              rows.append([
-                  stat,
-                  f"`{bid}`",
-                  fmt_num(cur_rt), fmt_num(base_rt), delta_rt_cell,
-                  fmt_num(cur_ct), fmt_num(base_ct), delta_ct_cell
+              rows_rt.append([
+                  stat_rt, f"`{bid}`",
+                  fmt_num(cur_rt), fmt_num(base_rt),
+                  fmt_pct(d_rt, highlight=is_rt_reg)
+              ])
+              rows_ct.append([
+                  stat_ct, f"`{bid}`",
+                  fmt_num(cur_ct), fmt_num(base_ct),
+                  fmt_pct(d_ct, highlight=is_ct_reg)
               ])
 
-          # ----- compose CHECK body -----
-          header = [
-            "| status | benchmark_id | current FPS | baseline FPS | Δ FPS | current compile | baseline compile | Δ compile |",
-            "|:------:|:-------------|-----------:|-------------:|------:|----------------:|-----------------:|---------:|",
+          header_rt = [
+            "| status | benchmark_id | current FPS | baseline FPS | Δ FPS |",
+            "|:------:|:-------------|-----------:|-------------:|------:|",
           ]
-          table_lines = header + ["| "+" | ".join(r)+" |" for r in rows]
-
-          summary_top = []
-          summary_top.append(f"Baselines considered: **{len(rev_order)}** commits")
+          header_ct = [
+            "| status | benchmark_id | current compile | baseline compile | Δ compile |",
+            "|:------:|:-------------|----------------:|-----------------:|---------:|",
+          ]
+          table_rt = header_rt + ["| " + " | ".join(r) + " |" for r in rows_rt]
+          table_ct = header_ct + ["| " + " | ".join(r) + " |" for r in rows_ct]
+
+          # ----- baseline commit list -----
+          blist = [f"- Commit {i}: {sha}" for i, sha in enumerate(rev_order, 1)]
+          baseline_block = ["**Baselines considered:** " + f"**{len(rev_order)}** commits"] + blist
+
+          # ----- CHECK body (always) -----
+          check_parts = []
+          check_parts += baseline_block
+          check_parts += ["", f"Thresholds: runtime ≤ −{tol_rt:.0f}%, compile ≥ +{tol_ct:.0f}%", ""]
+          check_parts += ["### Runtime FPS", *table_rt, ""]
+          check_parts += ["### Compile Time", *table_ct, ""]
+          check_body = "\n".join(check_parts)
+
+          # ----- COMMENT body (only if regressions) -----
           if reg_found:
-              summary_top.append(f"Regressions detected (runtime ≤ −{tol_rt:.0f}%, compile ≥ +{tol_ct:.0f}%).")
-          else:
-              summary_top.append("No regressions detected.")
-
-          check_body = "\n".join(summary_top + ["", "<details><summary>Benchmark details</summary>", "", *table_lines, "", "</details>"])
-
-          # ----- compose COMMENT body -----
-          if True: #reg_found:
-              comment_body = "\n".join([
-                  ":warning: **Benchmark comparison vs W&B baselines**",
-                  f"- Baselines considered: **{len(rev_order)}** commits",
-                  f"- Thresholds: runtime ≤ −{tol_rt:.0f}%, compile ≥ +{tol_ct:.0f}%",
+              comment_parts = [
+                  ":warning: **Benchmark Regression Detected**",
+                  *baseline_block,
                   "",
-                  *table_lines
-              ])
+                  f"Thresholds: runtime ≤ −{tol_rt:.0f}%, compile ≥ +{tol_ct:.0f}%",
+                  "",
+                  "### Runtime FPS",
+                  *table_rt,
+                  "",
+                  "### Compile Time",
+                  *table_ct,
+              ]
+              comment_body = "\n".join(comment_parts)
           else:
               comment_body = ""
 
@@ -321,7 +339,7 @@ jobs:
             echo "SCRIPT_OUTPUT=" >> "$GITHUB_ENV"
           fi
 
-      - name: Add PR comment (only if regressions)
+      - name: Add PR comment
         if: ${{ steps.pr.outputs.pr_number != '' && env.SCRIPT_OUTPUT != '' }}
         uses: actions/github-script@v7
         env:
@@ -336,7 +354,7 @@ jobs:
               body: process.env.COMMENT_BODY
             });
 
-      - name: Publish PR check (always show full table)
+      - name: Publish PR check
         if: always()
         uses: actions/github-script@v7
         env:
@@ -349,8 +367,8 @@ jobs:
             const hasRegs = (process.env.HAS_REGRESSIONS || 'false').trim() === 'true';
             const conclusion = 'success';
             const summary = hasRegs
-              ? 'Regressions detected. See the table below.'
-              : 'No regressions detected. See the table below.';
+              ? '🔴 Regressions detected. See tables below.'
+              : '✅ No regressions detected. See tables below.';
             await github.rest.checks.create({
               owner: context.repo.owner,
               repo: context.repo.repo,