Skip to content

Commit a4fae7d

Browse files
committed
foo
1 parent 0cdcde1 commit a4fae7d

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

.github/workflows/alarm.yml

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -261,22 +261,30 @@ jobs:
261261
lines.append("")
262262
263263
if runtime_regs:
264-
runtime_regs.sort(key=lambda x: x[3])
265-
lines += ["**Runtime FPS regressions (vs mean of other revisions)**",
266-
"| benchmark_id | current | baseline mean | delta % |",
267-
"|---|---:|---:|---:|"]
264+
runtime_regs.sort(key=lambda x: x[3]) # more negative first
265+
lines += [
266+
"**Runtime FPS regressions (vs mean of other commits)**",
267+
"| benchmark_id | current | baseline mean | delta % |",
268+
"|---|---:|---:|---:|",
269+
]
268270
for bid, cur, base, d in runtime_regs[:20]:
269271
lines.append(f"| `{trunc(bid)}` | {cur:,.0f} | {base:,.0f} | {d:.2f}% |")
270-
if len(runtime_regs)>20: lines.append("_Only first 20 shown._"); lines.append("")
272+
if len(runtime_regs) > 20:
273+
lines.append("_Only first 20 shown._")
274+
lines.append("")
271275
272276
if compile_regs:
273-
compile_regs.sort(key=lambda x: -x[3])
274-
lines += ["**Compile-time regressions (vs mean of other revisions)**",
275-
"| benchmark_id | current | baseline mean | delta % |",
276-
"|---|---:|---:|---:|"]
277+
compile_regs.sort(key=lambda x: -x[3]) # more positive first
278+
lines += [
279+
"**Compile-time regressions (vs mean of other commits)**",
280+
"| benchmark_id | current | baseline mean | delta % |",
281+
"|---|---:|---:|---:|",
282+
]
277283
for bid, cur, base, d in compile_regs[:20]:
278284
lines.append(f"| `{trunc(bid)}` | {cur:,.0f} | {base:,.0f} | {d:.2f}% |")
279-
if len(compile_regs)>20: lines.append("_Only first 20 shown._"); lines.append("")
285+
if len(compile_regs) > 20:
286+
lines.append("_Only first 20 shown._")
287+
lines.append("")
280288
281289
tag = f"bench-guard-run:{wr_id}"
282290
lines.append(f"<!-- {tag} -->")

0 commit comments

Comments
 (0)