Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub commit status “context” used by promote.sh so parallel promote jobs don’t overwrite each other’s status check.
Changes:
- Adds a computed
checkContextvariable that includesBUILD_NAME - Uses
checkContextwhen posting the GitHub commit status - Documents the reason for the new context format in-code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c001ee2 to
2d65a24
Compare
julien-carsique-sonarsource
requested changes
Feb 17, 2026
a53ac3c to
5e3fc45
Compare
Make check_context a function parameter and call github_notify_promotion
twice: once with the new BUILD_NAME-scoped context for unique parallel
checks, and once with the legacy repox-${GITHUB_REF_NAME} context for
backward compatibility.
5e3fc45 to
c8d5d80
Compare
SonarQube reviewer guide
|
julien-carsique-sonarsource
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Problem
When multiple promote jobs run in parallel (e.g. in a monorepo with consolidated matrix builds), they all write to the same GitHub commit status check. The check context was
repox-${GITHUB_REF_NAME}, which is identical for all promote jobs in the same workflow run.Consequences:
Example: In sonarqube-unification, a consolidated workflow builds 6 capabilities in parallel (entitlements, organizations, template, unified-core, users, integration-bindings). Each runs the promote action with its own
BUILD_NAME(e.g.sonarqube-unification-template,sonarqube-unification-entitlements). All 6 write torepox-64/mergeand only one survives.Solution
Make
check_contexta parameter ofgithub_notify_promotion()and call it twice frompromote():repox-${BUILD_NAME}-${GITHUB_REF_NAME}— unique context per build (e.g.repox-sonarqube-unification-template-64/merge)repox-${GITHUB_REF_NAME}— legacy context for backward compatibility (deprecated)This way each parallel promote job creates its own distinct check, while the old check context is also written so that existing downstream scripts continue to work during a migration period.
Backward compatibility
repoxorpromote(e.g. sonarqube-unification'sresolve.py) continue to work unchanged.Testing