Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-23970 Add conditions to CI #613

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

davividal
Copy link
Collaborator

@davividal davividal commented Jan 6, 2025

@jCOTINEAU
Copy link
Collaborator

jCOTINEAU commented Jan 7, 2025

the chart packagings jobs does not works, and it does not looks like a false positive ? might be a missing source cirrus-env BUILD in the package tasks.

.cirrus/sign_chart.sh Outdated Show resolved Hide resolved
.cirrus/sign_chart.sh Outdated Show resolved Hide resolved
.cirrus/sign_chart.sh Show resolved Hide resolved
.cirrus/sign_chart.sh Show resolved Hide resolved
tests/ci-tests/google-marketplace/.cirrus.expected.yml Outdated Show resolved Hide resolved
@jCOTINEAU
Copy link
Collaborator

Could you also trigger some blank commit to validate the conditional behavior does trigger well ?

@davividal davividal force-pushed the dkv/sonar-23970-conditional-ci branch from 981ac37 to 2545a27 Compare January 9, 2025 10:23
@davividal davividal requested a review from jCOTINEAU January 9, 2025 12:58
.cirrus/sign_chart.sh Show resolved Hide resolved
.cirrus/sign_chart.sh Outdated Show resolved Hide resolved
.cirrus/tasks_templates.yml Outdated Show resolved Hide resolved
.cirrus/tasks_templates.yml Outdated Show resolved Hide resolved
.cirrus/tasks_templates.yml Outdated Show resolved Hide resolved
.cirrus/tasks_gcp_marketplace.yml Outdated Show resolved Hide resolved
@davividal davividal requested review from jCOTINEAU and removed request for carminevassallo January 9, 2025 15:17
Copy link
Collaborator

@jCOTINEAU jCOTINEAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ready to be merged.

@davividal davividal force-pushed the dkv/sonar-23970-conditional-ci branch from 3fa4201 to 9cc7746 Compare January 9, 2025 15:41
Copy link

sonarqube-next bot commented Jan 9, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@davividal davividal merged commit 8247302 into master Jan 10, 2025
12 checks passed
@davividal davividal deleted the dkv/sonar-23970-conditional-ci branch January 10, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants