Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .yaml extension in change-admin-password-hook template #615

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LuisPiedra
Copy link

All other YAML files in templates folder use .yaml extension and change-admin-password-hook.yml is the only one using .yml, which it is against Helm best practices (https://helm.sh/docs/chart_best_practices/templates/#structure-of-templates). Although Helm still accepts .yml extension, some other tools can be picky about that and ignore those files.

Please ensure your pull request adheres to the following guidelines:

  • explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Document your Changes in the CHANGELOG.md file of the respected chart as well as the Chart.yaml

@davividal
Copy link
Collaborator

Hey @LuisPiedra.

Nice catch, thank you!
Can you please apply this in the sonarqube-dce chart and rebase your branch against master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants