-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend UnitTestHelper with IsIgnoredTestMethod #7333
Conversation
@pavel-mikula-sonarsource As this involves changing so three existing rules, I decided to make a small separate PR. |
What about changing the API to: |
87ad198
to
757fa0f
Compare
@pavel-mikula-sonarsource Any ETA on this? |
757fa0f
to
f963200
Compare
/azp run |
No commit pushedDate could be found for PR 7333 in repo SonarSource/sonar-dotnet |
I'd keep the API as is. It's not use that often |
I'm sorry, we don't give ETAs in general. And I tend to be pretty busy all the time :) |
There's some infra issue with running CI :/ |
Changes looks good, I'll need to run CI to verify the results. |
/azp run |
No commit pushedDate could be found for PR 7333 in repo SonarSource/sonar-dotnet |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to fix the UTs :)
We did quite some changes on Java ITs - rebase could fix those.
Then I can take care of .NET ITs.
97d0baa
to
ef93b9f
Compare
Did a rebase. |
ef93b9f
to
a611283
Compare
Another rebase. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
|
a611283
to
48dd97b
Compare
another rebase. |
@Corniel Can you take a look at the UTs? They were failing during the previous run and I haven't seen a change there |
@pavel-mikula-sonarsource The |
Due to the changes in the repo, I can not build stuff locally anymore. I close this one. |
Hi, Otherwise: Yes, Which variable concerns you? If I remember correctly, we did not add or remove any recently. From my point of view, we have way too many of them and I'd like to reduce that in the future. One thing that is problematic to build the project outside our environment is the
Other than that, it should be buildable and testable locally. What's the problem you're facing? |
Well, I can not build anymore due to other restrictions introduced. I've to log on to repox.jfrog.io, for which I obvioulsy have no credentials. |
That's why you need to delete |
I now. But that is annoying. it also makes that creating PR's is more effort: I've continually have to revert and redo the deletion. I like working on this repo, but as long as this is required, I'll do no further contributions. |
We're unfortunately required to use authenticated calls via jfrog.io, so we can't change that. I case you'd have a better idea how to solve this (having local VS builds picking up this special nuget.config file by default while for external PRs have a mechanism to ignore it), we'd like to know. |
@pavel-mikula-sonarsource I understand that you can't change that. I do not have a better idea. Removing the I could not found anything that makes it conditional once its on disk. |
Based on this conversation, a possible idea came to my mind. I'll need to check few things to verify if it would work. I'll let you know |
As discussed in #6185, some extended unit test detection logic should be centralized.