Extend UnitTestHelper with IsIgnoredTestMethod

[Corniel]

As discussed in #6185, some extended unit test detection logic should be centralized.

[Corniel]

@pavel-mikula-sonarsource As this involves changing so three existing rules, I decided to make a small separate PR.

[Corniel]

@pavel-mikula-sonarsource

What about changing the API to: IsTestMethod(bool includeIgnoredTests: false)?

[Corniel]

@pavel-mikula-sonarsource Any ETA on this?

[pavel-mikula-sonarsource]

/azp run

[azure-pipelines]

No commit pushedDate could be found for PR 7333 in repo SonarSource/sonar-dotnet

[pavel-mikula-sonarsource]

I'd keep the API as is. It's not use that often

[pavel-mikula-sonarsource]

I'm sorry, we don't give ETAs in general. And I tend to be pretty busy all the time :)

[pavel-mikula-sonarsource]

There's some infra issue with running CI :/

[pavel-mikula-sonarsource]

Changes looks good, I'll need to run CI to verify the results.

[pavel-mikula-sonarsource]

/azp run

[azure-pipelines]

No commit pushedDate could be found for PR 7333 in repo SonarSource/sonar-dotnet

[pavel-mikula-sonarsource]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[pavel-mikula-sonarsource]

We'll need to fix the UTs :)
We did quite some changes on Java ITs - rebase could fix those.
Then I can take care of .NET ITs.

[Corniel]

Did a rebase.

[Corniel]

Another rebase.

[pavel-mikula-sonarsource]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[Corniel]

another rebase.

[pavel-mikula-sonarsource]

@Corniel Can you take a look at the UTs? They were failing during the previous run and I haven't seen a change there

[Corniel]

@pavel-mikula-sonarsource The regression-test.ps1 is gone?! Besides that, the setup still requires some environment variables that would not like to configure on my work laptop.

[Corniel]

Due to the changes in the repo, I can not build stuff locally anymore. I close this one.

[pavel-mikula-sonarsource]

Hi,
in case you're interested in recreating this PR, the UnitTestHelper.cs is gone and IsIgnoredTestMethod should be added to SonarAnalyzer.Core/Semantics/Extensions/IMethodSymbolExtensions.cs

Otherwise:

Yes, regression-test.ps1 is gone. We've moved our ITs to internal QA pipeline that is not in this repo. From your point of view, there's one less thing to worry about, as running ITs was close to impossible anyway for external PRs.

Which variable concerns you? If I remember correctly, we did not add or remove any recently. From my point of view, we have way too many of them and I'd like to reduce that in the future.

One thing that is problematic to build the project outside our environment is the NuGet.config file. We've added this to the contributing-analyzer.md:

Before following any of the guides below, if you are external contributor you need to delete analyzers\NuGet.Config.

Other than that, it should be buildable and testable locally. What's the problem you're facing?

[Corniel]

Well, I can not build anymore due to other restrictions introduced. I've to log on to repox.jfrog.io, for which I obvioulsy have no credentials.

[pavel-mikula-sonarsource]

That's why you need to delete analyzers\NuGet.Config file. Than your build will use the usual nuget.org package source

[Corniel]

I now. But that is annoying. it also makes that creating PR's is more effort: I've continually have to revert and redo the deletion. I like working on this repo, but as long as this is required, I'll do no further contributions.

[pavel-mikula-sonarsource]

We're unfortunately required to use authenticated calls via jfrog.io, so we can't change that.

I case you'd have a better idea how to solve this (having local VS builds picking up this special nuget.config file by default while for external PRs have a mechanism to ignore it), we'd like to know.

[Corniel]

@pavel-mikula-sonarsource I understand that you can't change that.

I do not have a better idea. Removing the nuget.config would be helping me, but would make the live of all of you obviously worse. Unless you only need this settings on dev environments of Sonar employees, than you could remove it and make it part of your root setup. (I can think of scenario's were that is will not fly on other reasons).

I could not found anything that makes it conditional once its on disk.

[pavel-mikula-sonarsource]

Based on this conversation, a possible idea came to my mind. I'll need to check few things to verify if it would work. I'll let you know