SONARJAVA-5341 Fix FP reported for too many cases on switches when enum types are unknown #5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainbrenguier
force-pushed
the
romain/fix-fp-enum-switch
branch
from
2b7c7e9 to
8af3a4a
Compare
alban-auzeill
requested changes
Feb 26, 2025
Comment on lines
25
to
28
| public static TernaryValue ofBoolean(@Nullable Boolean b) { | ||
| if (b == null) { | ||
| return UNKNOWN; | ||
| } | ||
| return b ? TRUE : FALSE; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure about the usefulness of ofBoolean compared to of, I don't see where there could be ambiguity.
When we have a boolean like isEnum(), I would prefer having a dedicated method instead of converting it to Boolean in a method that converts it back to boolean.
Suggested change
| public static TernaryValue ofBoolean(@Nullable Boolean b) { | |
| if (b == null) { | |
| return UNKNOWN; | |
| } | |
| return b ? TRUE : FALSE; | |
| } | |
| public static TernaryValue of(boolean b) { | |
| return b ? TRUE : FALSE; | |
| } | |
| public static TernaryValue of(@Nullable Boolean b) { | |
| return b == null ? UNKNOWN : of(b.booleanValue()); | |
| } |
romainbrenguier
force-pushed
the
romain/fix-fp-enum-switch
branch
from
8af3a4a to
b03a509
Compare
To handle better the cases where something is unknown.
romainbrenguier
force-pushed
the
romain/fix-fp-enum-switch
branch
from
b03a509 to
55ceea5
Compare
|
alban-auzeill
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5341
When we don't know if the symbol in the switch is an enum, we shouldn't raise that issue.