Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARJAVA-5392 S5804 should not throw an NPE when visiting constructors #5055

Merged
merged 1 commit into from
Mar 18, 2025
Merged

SONARJAVA-5392 S5804 should not throw an NPE when visiting constructors #5055

merged 1 commit into from
Mar 18, 2025

Conversation

dorian-burihabwa-sonarsource
Copy link
Contributor

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource commented Mar 17, 2025 •
edited by jira bot
Loading

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource requested a review from a team March 17, 2025 16:57
@dorian-burihabwa-sonarsource
SONARJAVA-5392 S5804 should not throw an NPE when visiting constructors
f0b02c5 
Fixed a bug where the check would fail because it would attempt to
lookup the method name of constructor that was not collected before.
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

erwan-serandour
erwan-serandour approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@erwan-serandour erwan-serandour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource merged commit a8d1979 into master Mar 18, 2025
16 checks passed
@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource deleted the SONARJAVA-5392 branch March 18, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwan-serandour erwan-serandour erwan-serandour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorian-burihabwa-sonarsource @erwan-serandour