Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARJAVA-5352 Fix multi-quality rules severity mappings #5056

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

leonardo-pilastri-sonarsource
Copy link
Contributor

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource commented Mar 18, 2025

SONARJAVA-5352

This fix was introduced on the 8.9 bugfix branch for the LTA of SQ, and it fixes the mapping of multi-quality rules between their code.impacts and their defaultSeverity.

LOW to INFO

  • S1133
  • S1135
  • S3688

LOW to MEDIUM

  • S6485
  • S6837
  • S6863
  • S6889
  • S6891
  • S6898
  • S6904
  • S6909
  • S6912
  • S6914
  • S6923
  • S6926

HIGH to BLOCKER:

  • S2115
  • S6437

Minor to Major

  • S6829
  • S6830
  • S6878
  • S6905

Major to Critical

  • S6809
  • S6814
  • S6816
  • S6817
  • S6818
  • S6857
  • S6876
  • S6877
  • S6881
  • S7178
  • S7184
  • S7185
  • S7186
  • S7190

- S1133
- S1135
- S3688

- S6485
- S6837
- S6863
- S6889
- S6891
- S6898
- S6904
- S6909
- S6912
- S6914
- S6923
- S6926

- S2115
- S6437

- S6829
- S6830
- S6878
- S6905

- S6809
- S6814
- S6816
- S6817
- S6818
- S6857
- S6876
- S6877
- S6881
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename the PR and update the commit message to include the transitions from one severity to the other (it looks like this was lost in the squash)

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource changed the title SONARJAVA-5352 Migrate LOW to INFO, HIGH to BLOCKER (#5039) SONARJAVA-5352 Migrate LOW to INFO, HIGH to BLOCKER Mar 19, 2025
@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource changed the title SONARJAVA-5352 Migrate LOW to INFO, HIGH to BLOCKER SONARJAVA-5352 Fix multi-quality rules severity mappings Mar 19, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running metadata update on top of these changes, it looks like we have a couple of new rules with changes to their severity that should probably be part of this PR:

  • S7178
  • S7184
  • S7185
  • S7186
  • S7190

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏿 Thanks for the changes!

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource merged commit 45f37f5 into master Mar 19, 2025
16 of 17 checks passed
@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource deleted the lp/cherry-pick-bugfix-branch branch March 19, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants