-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARJAVA-5352 Fix multi-quality rules severity mappings #5056
SONARJAVA-5352 Fix multi-quality rules severity mappings #5056
Conversation
- S1133 - S1135 - S3688 - S6485 - S6837 - S6863 - S6889 - S6891 - S6898 - S6904 - S6909 - S6912 - S6914 - S6923 - S6926 - S2115 - S6437 - S6829 - S6830 - S6878 - S6905 - S6809 - S6814 - S6816 - S6817 - S6818 - S6857 - S6876 - S6877 - S6881
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename the PR and update the commit message to include the transitions from one severity to the other (it looks like this was lost in the squash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running metadata update on top of these changes, it looks like we have a couple of new rules with changes to their severity that should probably be part of this PR:
- S7178
- S7184
- S7185
- S7186
- S7190
ffb571f
to
a604dab
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏿 Thanks for the changes!
SONARJAVA-5352
This fix was introduced on the 8.9 bugfix branch for the LTA of SQ, and it fixes the mapping of multi-quality rules between their
code.impacts
and theirdefaultSeverity
.LOW to INFO
LOW to MEDIUM
HIGH to BLOCKER:
Minor to Major
Major to Critical