SONARJAVA-5421 Fix NPE in S2225 on return in void lambdas #5065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh with NPE Case of a lambda returning void in a toString method.
To avoid false positives in lambdas declared inside toString methods.
|
dorian-burihabwa-sonarsource
approved these changes
Mar 25, 2025
dorian-burihabwa-sonarsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5421
With this changes, we check whether we are inside a lambda in the interesting method before looking at return statement.
This has the effect of avoiding some null pointer exceptions.