-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SONARKT-552 Migrate DelegationPatternCheck to kotlin-analysis-api #566
base: master
Are you sure you want to change the base?
Conversation
8c5daba
to
4aed8c2
Compare
@@ -1,6 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues disappeared from the Kotlin compiler are related to the fact, that we only pass Kotlin files to the analysis and don't provide classpath.
The issues disappear because for some parameters we can't resolve types (receive KaErrorType) and that's why we can't guarantee that there was a match of method signatures. The types that are unresolved are represented by classes written in Java (for example KtExpression).
So far I think we can accept this change as this is related to the analysis misconfiguration and not the rule behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously an empty String was returned as a fully qualified name of an Error type. Since ""
is equal to ""
, the issue appeared by accident and by accident those issues happened to be TP.
Before we introduced generation of Binding context in all cases, these issues weren't triggered as types weren't resolved at all.
a6adc77
to
4b4f1d4
Compare
e4826d9
to
b72997e
Compare
b72997e
to
6190bad
Compare
|
SONARKT-552
Part of
SONARKT-532