SONARRUBY-129 Get rid of jruby gradle plugin#109
Merged
Conversation
rombirli
force-pushed
the
rombirli/get-rid-jruby-gradle-plugin
branch
from
4ece07f to
f463956
Compare
rombirli
changed the title
rombirli
force-pushed
the
rombirli/get-rid-jruby-gradle-plugin
branch
from
f463956 to
7b23863
Compare
dorian-burihabwa-sonarsource
approved these changes
Mar 11, 2026
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
Thank you for the clean up work on the PR and commits. I think we could still update the old around the explicit inclusion of the parser gems
sonar-ruby-plugin/build.gradle
Outdated
Comment on lines
26
to
32
| @@ -53,9 +30,9 @@ dependencies { | |||
| // http://rubygems-proxy.torquebox.org/releases/rubygems/racc/1.5.2/racc-1.5.2-java.pom | |||
| // But "rubygems-proxy.torquebox.org" server does not exist anymore. | |||
| // The bellow function "downloadFromRubygems" is a workaround to this problem | |||
Contributor
There was a problem hiding this comment.
We should delete or update these lines as we are keeping the behavior despite dropping the pluign
rombirli
force-pushed
the
rombirli/get-rid-jruby-gradle-plugin
branch
from
7b23863 to
e2f19b5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is split into 3 commits:
Replace JRuby plugin gem unpacking with native Gradle taskssonar-ruby-pluginLoad bundled parser gems via classloader URIsRubyConverterto initialize JRuby fromuri:classloader:load pathsExplode shadowBugWorkaround.jar in the final plugin artifact