-
Notifications
You must be signed in to change notification settings - Fork 144
SCAN4NET-976 Hackathon 2025: Make project.assets.json available in analyzers and java ProjectSensor's #2894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
martin-strecker-sonarsource
wants to merge
4
commits into
master
Choose a base branch
from
Martin/AddProjectAssetJson
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
815ba6a
Add ProjectAssetsFile property to WriteProjectConfigFile
martin-strecker-sonarsource 55645f5
Write ProjectAssetsFile location to ProjectConfig
martin-strecker-sonarsource f8da924
Add ProjectAssetsFile to SonarQubeSetting
martin-strecker-sonarsource 1152218
Fix WriteProjectConfigFileTests
martin-strecker-sonarsource File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,10 +18,8 @@ | |
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
| */ | ||
|
|
||
| using System.IO; | ||
| using Microsoft.Build.Framework; | ||
| using Microsoft.Build.Utilities; | ||
| using SonarScanner.MSBuild.Common; | ||
|
|
||
| namespace SonarScanner.MSBuild.Tasks; | ||
|
|
||
|
|
@@ -54,6 +52,8 @@ public class WriteProjectConfigFile : Task | |
|
|
||
| public string TargetFramework { get; set; } | ||
|
|
||
| public string ProjectAssetsFile { get; set; } | ||
|
|
||
| #endregion Input properties | ||
|
|
||
| [Output] | ||
|
|
@@ -66,12 +66,13 @@ public override bool Execute() | |
| ProjectConfigFilePath = Path.Combine(ConfigDir, FileConstants.ProjectConfigFileName); | ||
| var config = new ProjectConfig | ||
| { | ||
| AnalysisConfigPath= AnalysisConfigPath, | ||
| ProjectPath= ProjectPath, | ||
| FilesToAnalyzePath= FilesToAnalyzePath, | ||
| OutPath= OutPath, | ||
| AnalysisConfigPath = AnalysisConfigPath, | ||
| ProjectPath = ProjectPath, | ||
| FilesToAnalyzePath = FilesToAnalyzePath, | ||
| OutPath = OutPath, | ||
| ProjectType = IsTest ? ProjectType.Test : ProjectType.Product, | ||
| TargetFramework = TargetFramework | ||
| TargetFramework = TargetFramework, | ||
| ProjectAssetsFile = ProjectAssetsFile, | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes the file path available in the Roslyn analyzer. |
||
| }; | ||
| config.Save(ProjectConfigFilePath); | ||
| return true; | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the ProjectAssetsFile path available in the Java ProjectSensor.