Skip to content

Update Maven dependencies (major) #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Update Maven dependencies (major) #647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<sonarlint.core.version>10.47.0.84936</sonarlint.core.version>
<slf4j.version>2.0.17</slf4j.version>
<!-- Version used by Xodus -->
<kotlin.version>1.6.10</kotlin.version>
<kotlin.version>2.3.20</kotlin.version>
<!-- analyzers used for tests -->
<sonar.java.version>8.22.0.41895</sonar.java.version>
<sonar.java.se.version>8.16.3.1589</sonar.java.se.version>
Expand All @@ -54,7 +54,7 @@
<groupId>org.eclipse.lsp4j</groupId>
<artifactId>org.eclipse.lsp4j</artifactId>
<!-- should be the >= than in sonarlint-rpc-java-client -->
<version>0.24.0</version>
<version>1.0.0</version>
Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 56 says this version should be >= what sonarlint-rpc-java-client uses. sonarlint-rpc-java-client 10.47.0.84936 was almost certainly compiled against lsp4j 0.24.x — lsp4j 1.0.0 only landed in February 2026.

lsp4j 1.0.0 removes several previously deprecated APIs, most critically the static factory methods Either.forLeft() / Either.forRight() (replaced by TypeUtils helpers). If the RPC client calls any of those removed methods, the fat JAR will throw NoSuchMethodError at runtime — this would not be caught by SonarCloud static analysis.

Please confirm one of the following before merging:

  1. sonarlint-rpc-java-client 10.47.0.84936 has already been updated to be compatible with lsp4j 1.0.0, or
  2. The integration/medium tests (AbstractLanguageServerMediumTests) ran cleanly with this version bump — those exercise the full RPC path and would surface classpath errors.

If neither is true, this upgrade needs to be coordinated with a matching sonarlint-core release that targets lsp4j 1.0.0.

</dependency>
<dependency>
<groupId>org.sonarsource.sonarlint.core</groupId>
Expand Down Expand Up @@ -100,7 +100,7 @@
<dependency>
<groupId>org.eclipse.jgit</groupId>
<artifactId>org.eclipse.jgit</artifactId>
<version>6.10.1.202505221210-r</version>
<version>7.6.0.202603022253-r</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
Expand All @@ -119,7 +119,7 @@
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>5.9.0</version>
<version>6.0.3</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
Loading