Skip to content

SLLS-506 Renovate - Update all minor/patch versions#657

Open
nquinquenel wants to merge 4 commits intomasterfrom
renovate/all-minor-patch
Open

SLLS-506 Renovate - Update all minor/patch versions#657
nquinquenel wants to merge 4 commits intomasterfrom
renovate/all-minor-patch

Conversation

@nquinquenel
Copy link
Member

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Renovate - Update all minor/patch versions SLLS-506 Renovate - Update all minor/patch versions Mar 23, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Mar 23, 2026

SLLS-506

@sonarqube-next
Copy link

@nquinquenel nquinquenel marked this pull request as ready for review March 23, 2026 20:12
@sonar-review-alpha
Copy link

sonar-review-alpha bot commented Mar 23, 2026

Summary

Dependency updates across test and build tooling

This PR updates multiple Maven dependencies, primarily test dependencies and build plugins. Notable updates include:

  • Kotlin: 1.6.10 → 1.9.21 (used indirectly via Xodus)
  • OkHttp MockWebServer: 5.0.0-alpha.8 → 5.3.2 (alpha to stable release)
  • Testing libraries: JUnit Jupiter 5.9.0 → 5.14.3, Mockito 5.9.0 → 5.23.0, Awaitility 4.2.1 → 4.3.0
  • Utilities: commons-lang3, commons-codec, picocli (patch/minor bumps)
  • Build plugins: JaCoCo 0.8.11 → 0.8.14

The PR also includes necessary code updates to accommodate MockResponse API changes in okhttp5 (shifting from setter methods to Builder pattern).

What reviewers should know

What changed:

  • Review pom.xml for all dependency version bumps (lines 30, 82, 87, 98, 122, 127, 140, 142, 158, 360)
  • The okhttp MockWebServer update (5.0.0-alpha.8 → 5.3.2) is the most significant—it moved from alpha to a stable release and has API changes
  • Test code updates in ConnectedModeMediumTests.java and MockWebServerExtension.java reflect the new MockResponse Builder pattern required by okhttp5

Things to watch:

  • Kotlin 1.9.21 is significantly newer than 1.6.10—verify this doesn't conflict with any custom Kotlin code or plugins
  • MockWebServer API changes (setResponseCode → code, setBody → body, shutdown → close) are consistently applied across all test mocks
  • The afterAll method signature change (removed IOException throws) is a consequence of server.close() not throwing checked exceptions

Start here:

  1. Check if CI/tests pass (all changes appear mechanical and API-driven)
  2. Verify Kotlin version bump doesn't cause compatibility issues with existing code or plugins
  3. Skim the MockResponse updates to confirm consistency (they're mechanical builder pattern conversions)

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean dependency upgrade. The API adaptations for okhttp5's MockResponse builder pattern and MockWebServer.close() are applied consistently and correctly throughout the test utilities and medium tests.

🗣️ Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant