Skip to content

Conversation

@antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Nov 29, 2024

Follow-up to #152 with minor adjustments to the README.

@antonioaversa antonioaversa marked this pull request as ready for review November 29, 2024 08:38
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't mention the Java keystore, as this is implementation details.

Also, I know the env variable is named ROOT_CERT, but this is misleading. It doesn't have to be a root certificate. It can be the server certificate or any other intermediate CA certificate.

@antonioaversa
Copy link
Contributor Author

Please don't mention the Java keystore, as this is implementation details.

Also, I know the env variable is named ROOT_CERT, but this is misleading. It doesn't have to be a root certificate. It can be the server certificate or any other intermediate CA certificate.

Understood. I have removed it from the description of the env var above. I couldn't find mentions of root certificate or Java keystore anywhere else in the repo, so we should be good now.

@antonioaversa antonioaversa merged commit f4eddd9 into dev Nov 29, 2024
28 checks passed
@antonioaversa antonioaversa deleted the antoni/improve-readme branch November 29, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants