SQSCANGHA-143 SubmitReview: Use Vault token#238
SQSCANGHA-143 SubmitReview: Use Vault token#238pavel-mikula-sonarsource wants to merge 1 commit intomasterfrom
Conversation
SummaryThis PR migrates the SubmitReview workflow from using GitHub Actions' built-in GITHUB_TOKEN to a Vault-managed token. The change fetches a repo-specific token from Vault alongside the existing JIRA credentials, and removes the now-unnecessary What reviewers should knowWhat changed:
Key points for review:
|
|
There was a problem hiding this comment.
LGTM! ✅
Clean, correct change. SubmitReview.yml now matches the Vault token pattern already in use by RequestReview.yml and PullRequestCreated.yml — the secret path, fromJSON extraction, and absence of pull-requests: read are all identical to those files.
One thing worth noting for a follow-up: PullRequestClosed.yml (not changed here) still uses secrets.GITHUB_TOKEN with pull-requests: read. If the goal is to fully migrate all backlog workflows to the Vault token, that file will need the same treatment.



With the latest automation changes, we need the Vault-based token now. It's the same token as the one in RequestReview.yml file. Please take care of merging this, I have 200+ repos to update.