Repo sync

.github/workflows/ci.yml

@@ -1,40 +1,140 @@
-name: CinderX
+name: CI
 
-on: [push]
+on: [push, pull_request]
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
+  run_tests:
+    name: Run Tests
+    runs-on: ${{ matrix.os }}
+    strategy:
+      # Don't let test failures on one platform block other platforms.
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, windows-latest]
+        # Test against multiple patch versions as CinderX references internal
+        # CPython functions and structures which can lead to ABI problems.  See
+        # cinderx/UpstreamBorrow for more details.
+        python-version: ['3.14.3', '3.14.4', '3.14.5', '3.14.6']
+        include:
+          - os: ubuntu-latest
+            python-version: '3.14t'
+          - os: ubuntu-latest
+            python-version: '3.15.0-beta.3'
 
     steps:
     - name: Checkout CinderX
-      uses: actions/checkout@v5
+      uses: actions/checkout@v6
 
     - name: Set up Python
       uses: actions/setup-python@v6
       with:
-        python-version: 3.14.3
+        python-version: ${{ matrix.python-version }}
+        allow-prereleases: true
 
     - name: Set up uv
       uses: astral-sh/setup-uv@v7
 
+    # Ubuntu's default GCC 13.3 hits an internal compiler error on
+    # SwapLockGuard's std::atomic_ref::compare_exchange_weak in
+    # cinderx/Jit/code_patcher.cpp, which is only compiled under
+    # Py_GIL_DISABLED. GCC 14 (which is also what manylinux_2_28
+    # ships via gcc-toolset-14) compiles it cleanly.
+    - name: Install GCC 14
+      if: runner.os == 'Linux'
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y gcc-14 g++-14
+        echo "CC=gcc-14" >> "$GITHUB_ENV"
+        echo "CXX=g++-14" >> "$GITHUB_ENV"
+
     - name: Create venv
-      run: uv venv --python 3.14.3
+      run: uv venv --python ${{ matrix.python-version }}
 
     - name: Build CinderX
-      run: uv build --wheel --python 3.14.3
+      # RuntimeTests do not support Windows or free-threaded builds yet.
+      env:
+        CINDERX_BUILD_RUNTIME_TESTS: ${{ runner.os != 'Windows' && matrix.python-version != '3.14t' && '1' || '' }}
+        CINDERX_RUNTIME_TESTS_OUTPUT_DIR: ${{ github.workspace }}/build/runtime-tests
+      run: uv build --wheel --python ${{ matrix.python-version }}
 
     - name: Install CinderX
-      run: uv pip install dist/*.whl
+      run: uv pip install cinderx --find-links dist --no-index
 
-    - name: Check CinderX Imports
+    - name: Check CinderX loads successfully
       run: |
         uv run python -c 'import cinderx ; print(cinderx.get_import_error()) ; assert cinderx.is_initialized()'
 
-    - name: Install Pytest
-      run: |
-        uv pip install pytest
+    - name: Install pytest
+      run: uv pip install pytest
+
+    - name: Run Tests
+      # Free-threaded builds aren't stable yet, so don't run the test suite
+      # against them.
+      if: matrix.python-version != '3.14t'
+      run: uv run pytest cinderx/PythonLib/test_cinderx/
 
-    - name: Run Basic JIT Tests
+    - name: Run native tests
+      if: runner.os != 'Windows' && matrix.python-version != '3.14t'
+      # Skip known OSS-only failures. Keep these narrow so RuntimeTests still
+      # provide useful signal.
+      # TODO(T275133043): burn these down as the underlying issues are fixed.
+      # Particularly the segfaults.
       run: |
-        uv run pytest cinderx/PythonLib/test_cinderx/test_jit_{async_generators,count_calls,disable,exception,frame,generators,global_cache,perf_map,specialization,type_annotations}.py
+        set -euo pipefail
+        common='AllPassesTest.*:AllPassesStaticTest.*:CmdLineTest.ExplicitJITDisable:UtilTest.SymbolizerResolvesDynamicSymbol'
+        arm64='LIRGeneratorTest.ParserTest:BackendTest.MoveSequenceOpt2Test:CodePatcherTest.DeoptPatch:BranchRelaxationTest.*'
+        macos='BackendTest.CastTest:BackendTest.InlineJITRTCastTest:SimplifyTest.BinaryOpWithObjSpecLeftAndRightFloatExactTurnsIntoLoadConst:NativeCallsTest.NativeInvokeBasic:SimplifyStaticTest.UnboxOfRandMaxIsEliminated:DeadCodeEliminationAndSimplifyTest.UnboxOfStaticGlobalIsOptimized:HIRBuilderStaticTest.CIntTypeEmitsConvertPrimitive:CodePatcherTest.DeoptPatch'
+        filter="-${common}"
+        if [[ "$RUNNER_ARCH" == "ARM64" ]]; then
+          filter="${filter}:${arm64}"
+        fi
+        if [[ "$RUNNER_OS" == "macOS" ]]; then
+          filter="${filter}:${macos}"
+        fi
+        package_parent="$(uv run python -c 'import pathlib, cinderx; print(pathlib.Path(cinderx.__file__).resolve().parent.parent)')"
+        export PYTHONPATH="$package_parent"
+        export GTEST_FILTER="$filter"
+        (cd cinderx && ../build/runtime-tests/RuntimeTests)
+
+  build_wheels:
+    name: Build wheels on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      # Don't let build failures on one platform block other platforms.
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, windows-latest]
+
+    steps:
+      - name: Checkout CinderX
+        uses: actions/checkout@v6
+
+      # cibuildwheel uses Python from a docker container.  The Python version is
+      # controlled by selecting the docker image version in pyproject.toml.
+      - name: Set up Python
+        uses: actions/setup-python@v6
+
+      - name: Install cibuildwheel
+        run: python -m pip install cibuildwheel
+
+      - name: Build wheels
+        run: python -m cibuildwheel --output-dir wheelhouse
+
+  build_sdist:
+    name: Build source distribution
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout CinderX
+        uses: actions/checkout@v6
+
+      # An sdist is just source code and doesn't contain compiled artifacts, it
+      # doesn't need to be built per patch version.
+      - name: Set up Python
+        uses: actions/setup-python@v6
+
+      - name: Install build tools
+        run: python -m pip install build
+
+      - name: Build sdist
+        run: python -m build --sdist

.github/workflows/docs.yml

@@ -0,0 +1,69 @@
+name: Documentation
+
+on:
+  # Deploy when docs or the website change on main.
+  push:
+    branches: [main]
+    paths:
+      - 'cinderx/website/**'
+  # Build-only check on PRs that touch docs.
+  pull_request:
+    paths:
+      - 'cinderx/website/**'
+  # Allow manual runs.
+  workflow_dispatch:
+
+# Allow the deploy job to publish to GitHub Pages via OIDC.
+permissions:
+  contents: read
+  pages: write
+  id-token: write
+
+# Only one concurrent deploy; don't cancel an in-progress production deploy.
+concurrency:
+  group: pages
+  cancel-in-progress: false
+
+jobs:
+  build:
+    if: github.repository == 'facebookincubator/cinderx'
+    name: Build site
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: cinderx/website
+    steps:
+      - name: Checkout CinderX
+        uses: actions/checkout@v6
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: yarn
+          cache-dependency-path: cinderx/website/yarn.lock
+
+      - name: Install dependencies
+        run: yarn install
+
+      - name: Build (fails on broken links)
+        run: yarn build
+
+      - name: Upload Pages artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: cinderx/website/build
+
+  deploy:
+    # Only deploy from main; PRs run the build job above as a check.
+    if: github.repository == 'facebookincubator/cinderx' && github.event_name != 'pull_request'
+    name: Deploy to GitHub Pages
+    needs: build
+    runs-on: ubuntu-latest
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+    steps:
+      - name: Deploy
+        id: deployment
+        uses: actions/deploy-pages@v4