Skip to content

test: add cli e2e snapshots#35

Merged
SoonIter merged 4 commits into
mainfrom
codex/e2e-cli-snapshots
Jun 12, 2026
Merged

test: add cli e2e snapshots#35
SoonIter merged 4 commits into
mainfrom
codex/e2e-cli-snapshots

Conversation

@SoonIter

Copy link
Copy Markdown
Owner

Summary

  • Add a dedicated Rstest e2e config and scripts for CLI product-level tests.
  • Add e2e cases that execute the built spm bin and snapshot terminal status, stdout, and stderr.
  • Cover help/version, init, add, install, update, patch/patch-commit, and CLI error paths.
  • Run e2e in CI after the package build and existing test suite.

Related Links

N/A

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Testing:

  • pnpm run test:e2e
  • pnpm run test:e2e:run
  • pnpm test
  • pnpm exec biome check e2e rstest.e2e.config.ts package.json biome.json .github/workflows/test.yml

Note: full pnpm check still reports pre-existing unrelated Biome findings in packages/skills-package-manager/src/npm/packPackage.ts, packages/skills-package-manager/src/pipeline/queue.ts, and website/theme/components/HomePage/index.css.

Copilot AI review requested due to automatic review settings June 11, 2026 11:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a dedicated end-to-end (E2E) test suite for the spm CLI using Rstest snapshots, and wires it into the repository’s test workflows so the built CLI output/behavior is validated at a product level.

Changes:

  • Introduces a separate rstest.e2e.config.ts and pnpm scripts to run CLI E2E tests (optionally after building).
  • Adds E2E test cases that execute the built packages/skills-package-manager/bin/spm.js and snapshot status, stdout, and stderr for key commands and error paths.
  • Extends Biome coverage to e2e/** and runs E2E tests in CI after the build + existing test suite.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rstest.e2e.config.ts Adds a dedicated Rstest configuration for E2E CLI tests.
package.json Adds test:e2e / test:e2e:run scripts for running the E2E suite.
e2e/helpers/cli.ts Adds helpers to run the built spm bin and normalize output for snapshots.
e2e/cases/help-version.test.ts Adds E2E coverage for --help and --version.
e2e/cases/init.test.ts Adds E2E coverage for init success and “manifest exists” failure.
e2e/cases/add.test.ts Adds E2E coverage for add list flow and agent install/link flow.
e2e/cases/install.test.ts Adds E2E coverage for install of linked skills and missing-manifest no-op.
e2e/cases/update.test.ts Adds E2E coverage for update skipping link specifiers and unknown targets.
e2e/cases/patch.test.ts Adds E2E coverage for patch and patch-commit flows.
e2e/cases/errors.test.ts Adds E2E coverage for unknown command and missing required args.
e2e/cases/snapshots/*.snap Adds snapshot baselines for all E2E cases.
biome.json Includes e2e/** in Biome’s file includes.
.github/workflows/test.yml Runs the E2E suite in CI after build + unit tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread e2e/helpers/cli.ts
Comment thread rstest.e2e.config.ts
@SoonIter

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ef5ceb365

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread biome.json Outdated
@SoonIter SoonIter merged commit 4d3d216 into main Jun 12, 2026
3 checks passed
@SoonIter SoonIter deleted the codex/e2e-cli-snapshots branch June 12, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants