Skip to content

Fix a pending test #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willnet merged 3 commits into from
Sep 12, 2025
+12 −11
Merged

Fix a pending test #387

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0b9928
Fix a pending test
willnet Jul 11, 2025
a02ed27
Fix grammer errors
willnet Jul 11, 2025
7052d0b
Move the process of resetting configuration values to the top level t…
willnet Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions spec/controllers/controller_oauth_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,31 +70,32 @@ def response.body
stub_all_oauth_requests!
end

context 'when callback_url begin with /' do
after do
sorcery_controller_external_property_set(:twitter, :callback_url, 'http://blabla.com')
sorcery_controller_external_property_set(:twitter, :original_callback_url, nil)
end

context 'when callback_url begins with /' do
before do
sorcery_controller_external_property_set(:twitter, :callback_url, '/oauth/twitter/callback')
end

it 'login_at redirects correctly' do
get :login_at_test
expect(response).to be_a_redirect
expect(response).to redirect_to('http://myapi.com/oauth/authorize?oauth_callback=http%3A%2F%2Ftest.host%2Foauth%2Ftwitter%2Fcallback&oauth_token=')
end
after do
sorcery_controller_external_property_set(:twitter, :callback_url, 'http://blabla.com')
end
end

context 'when callback_url begin with http://' do
context 'when callback_url begins with http://' do
before do
sorcery_controller_external_property_set(:twitter, :callback_url, '/oauth/twitter/callback')
sorcery_controller_external_property_set(:twitter, :callback_url, 'http://blabla.com/oauth/twitter/callback')
end
it 'login_at redirects correctly', pending: true do

it 'login_at redirects correctly' do
get :login_at_test
expect(response).to be_a_redirect
expect(response).to redirect_to('http://myapi.com/oauth/authorize?oauth_callback=http%3A%2F%2Fblabla.com&oauth_token=')
end
after do
sorcery_controller_external_property_set(:twitter, :callback_url, 'http://blabla.com')
expect(response).to redirect_to('http://myapi.com/oauth/authorize?oauth_callback=http%3A%2F%2Fblabla.com%2Foauth%2Ftwitter%2Fcallback&oauth_token=')
end
end

Expand Down