Change test domains to use "example.com" wherever possible#393
Merged
Conversation
Previously used domains like "blabla.com", "bla.com", and "bar.com" could exist in reality. Since IANA reserves example.com for documentation and examples, I replaced them with example.com whenever possible. The exception is test.host, which Rails uses as the default domain in tests (see: https://github.com/rails/rails/blob/d09c4bbfcadcd6b3af847a11608a63c0718158ed/actionpack/lib/action_dispatch/testing/test_request.rb#L11). Simply changing it to example.com causes tests to fail. While adding the following snippet to `spec_helper.rb` would make the tests pass, I decided to leave it as is since the motivation isn’t strong enough: ```ruby config.before(:each, type: :controller) do request.host = 'example.com' end ``` related url: Sorcery#387 (comment)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces test domains with IANA-reserved "example.com" domains to follow best practices for test data. Previously used domains like "blabla.com", "bla.com", and "bar.com" could potentially exist in reality, while example.com is officially reserved for documentation and testing purposes.
- Replaces potentially real domains with example.com in test files
- Updates OAuth callback URLs to use example.com
- Standardizes test email addresses to use example.com domain
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/shared_examples/user_shared_examples.rb | Updates test email addresses from potentially real domains to example.com |
| spec/shared_examples/user_oauth_shared_examples.rb | Changes OAuth callback URL from blabla.com to example.com |
| spec/shared_examples/user_brute_force_protection_shared_examples.rb | Updates authentication test email to use example.com |
| spec/controllers/controller_spec.rb | Replaces test email addresses in controller specs with example.com |
| spec/controllers/controller_session_timeout_spec.rb | Updates login test emails to use example.com domain |
| spec/controllers/controller_remember_me_spec.rb | Changes test email addresses to example.com in remember me functionality tests |
| spec/controllers/controller_oauth_spec.rb | Updates OAuth configuration URLs and test data to use example.com subdomains |
| spec/controllers/controller_oauth2_spec.rb | Replaces OAuth2 callback URLs and test data with example.com variants |
| spec/controllers/controller_http_basic_auth_spec.rb | Updates HTTP basic auth test email to example.com |
| spec/controllers/controller_brute_force_protection_spec.rb | Changes brute force protection test email to example.com |
| lib/sorcery/test_helpers/internal.rb | Updates default test user email in helper methods to example.com |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
willnet
added a commit
to Spone/sorcery
that referenced
this pull request
Dec 2, 2025
willnet
added a commit
to Spone/sorcery
that referenced
this pull request
Dec 2, 2025
willnet
added a commit
to Spone/sorcery
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously used domains like "blabla.com", "bla.com", and "bar.com" could exist in reality. Since IANA reserves example.com for documentation and examples, I replaced them with example.com whenever possible.
The exception is test.host, which Rails uses as the default domain in tests (see: https://github.com/rails/rails/blob/d09c4bbfcadcd6b3af847a11608a63c0718158ed/actionpack/lib/action_dispatch/testing/test_request.rb#L11). Simply changing it to example.com causes tests to fail. While adding the following snippet to
spec_helper.rbwould make the tests pass, I decided to leave it as is since the motivation isn’t strong enough:related url: #387 (comment)