Skip to content

fix LruCache insert #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkysg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix LruCache insert #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/angstrom-net/src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ impl<T: Hash + Eq> LruCache<T> {
/// If the set did have this value present, false is returned.
pub fn insert(&mut self, entry: T) -> bool {
if self.inner.insert(entry) {
if self.limit.get() == self.inner.len() {
if self.inner.len() > self.limit.get() {
// remove the oldest element in the set
self.remove_lru();
}
Expand Down Expand Up @@ -105,6 +105,7 @@ mod test {
cache.insert(new_entry);
assert!(cache.contains(new_entry));
assert!(!cache.contains(old_entry));
assert!(cache.contains("entry"));
}

#[test]
Expand Down