test: implement test suites for issues #473-476 - #535
Merged
Chuks-coderr merged 6 commits intoAug 30, 2026
Conversation
- Add tests for withdrawal during grace period after stream expiry - Test grace period expiration and sender reclaim capability - Verify default grace period value and withdrawal amount tracking
…m#474) - Add tests for NFT creation on stream initialization - Test NFT-based recipient transfer and stream ownership updates - Verify secondary market compatibility and term preservation
…oroStream#475) - Add tests for pagination with cursor-based iteration - Test page size enforcement and complete stream iteration - Verify ordering by creation ledger descending and cursor validation
…eam#476) - Add tests for rate adjustment maintaining USD-denominated value - Test max change percentage bounds and price multiplier calculations - Verify deposit preservation and sender authorization requirements
Add module declarations for grace_period_tests, stream_nft_tests, paginated_recipient_tests, and oracle_rate_adjustment_tests to compile test cases for issues SoroStream#473, SoroStream#474, SoroStream#475, and SoroStream#476
|
@kaivegascod-a11y Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement comprehensive test suites for four feature requests:
Changes
grace_period_tests.rs: Tests for withdrawal grace period after stream expirystream_nft_tests.rs: Tests for NFT minting and recipient transferpaginated_recipient_tests.rs: Tests for cursor-based paginationoracle_rate_adjustment_tests.rs: Tests for oracle price-driven rate updateslib.rs: Registered new test modulesTest Coverage
Each test module includes multiple test cases covering:
Closes #473
Closes #474
Closes #475
Closes #476