feat: fix memory leak, add estimateFee for all ops, add WalletConnect v2 and XDEFI adapters - #494
Merged
Chuks-coderr merged 2 commits intoAug 27, 2026
Conversation
… v2 and XDEFI adapters - Fix SoroStream#365: Add AbortController to StreamMonitor to cancel in-flight RPC requests when stop() is called during a pending poll, preventing resource leaks - Fix SoroStream#366: Add fee estimation methods for all stream operations (updateFlowRate, setOperator, operatorCancelStream, operatorTopUp, splitStream, transferStream, pause, resume) - Fix SoroStream#367: Add WalletConnect v2 adapter for mobile wallet support via QR code or deep link using @walletconnect/sign-client - Fix SoroStream#368: Add XDEFI wallet adapter for XDEFI browser extension users
|
@Smartdevs17 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 4 open issues:
Closes #365 - Fix memory leak in stream watcher polling loop
AbortControllertoStreamMonitorto cancel in-flight RPC requests whenstop()is called during a pending pollCloses #366 - Add estimateFee method for all stream operations
Added fee estimation methods for all stream operations:
estimateUpdateFlowRateFeeestimateSetOperatorFeeestimateOperatorCancelStreamFeeestimateOperatorTopUpFeeestimateSplitStreamFeeestimateTransferStreamFeeestimatePauseFeeestimateResumeFeeCloses #367 - Add WalletConnect v2 adapter for mobile wallet support
createWalletConnectV2Adapter()function@walletconnect/sign-clientto avoid SSR issuesstellar_signXDR, and session cleanupCloses #368 - Add XDEFI wallet adapter
createXDEFIAdapter()functionwindow.xdefi.stellarorwindow.xfi.stellarisConnected,getPublicKey, andsignTransactionChanges
src/stream-monitor.ts: Added AbortController for in-flight request cancellationsrc/SoroStreamClient.ts: Added 8 new fee estimation methods for all stream operationssrc/wallet.ts: Added WalletConnect v2 and XDEFI wallet adapterssrc/wallets.ts: Updated browser wallet barrel exportssrc/index.ts: Updated main barrel exportsAcceptance Criteria