feat(serialization): add buildUnsignedXdr helper for offline signing (#438) - #534
Merged
Chuks-coderr merged 2 commits intoAug 29, 2026
Merged
Conversation
…(issue SoroStream#438) - Implement buildUnsignedXdr helper function for constructing and serialising unsigned transaction XDR - Support operation name strings (createStream, withdraw, cancelStream, topUp, updateFlowRate, pause, resume, transferStream, etc.) and raw xdr.Operation - Add buildUnsignedXdr method to SoroStreamClient - Export buildUnsignedXdr and BuildUnsignedXdrParams from @sorostream/sdk - Add unit tests in test/offline_xdr_signing.test.ts
|
@adeniran19-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
buildUnsignedXdr(operation, params)helper function to construct and serialize Soroban contract transactions to base64 XDR without broadcasting them, enabling offline and air-gapped signing workflows.Summary of Changes
buildUnsignedXdrHelper: Implemented insrc/serialization.ts, supporting both named contract operations (createStream,withdraw,cancelStream,topUp,updateFlowRate,pauseStream,resumeStream,transferStream,setOperator,operatorCancelStream,operatorTopUp,addDelegate,revokeDelegate) and rawxdr.Operationobjects.buildUnsignedXdrmethod toSoroStreamClientusing the client'''s configured contract address and connected wallet.BuildUnsignedXdrParamsand exported helper from@sorostream/sdk.test/offline_xdr_signing.test.tsverifying unsigned transaction construction, envelope deserialization withTransactionBuilder.fromXDR, parameter overrides (fee, memo, sequence number, timeout, network passphrase), and error cases.Closes #438