fix(#255): deduplicate check-in deadline into shared helper - #309
Merged
icentedward76-sketch merged 1 commit intoAug 31, 2026
Conversation
Remove the private buildDeadline() in reminders.ts — a third verbatim copy of the lastCheckin + checkinPeriodDays * 86_400_000 formula that was already centralized in lib/deadlines.ts. Replace its one call site with nextCheckinDeadline(will) from the shared module. certificate.ts was already importing nextCheckinDeadline correctly, so no change was needed there. Add tests/unit/certificate.test.ts to assert downloadWillCertificate's 'Next check-in due' PDF line matches nextCheckinDeadline's output for the same Will fixture, satisfying the acceptance criterion from SoroWill#255.
|
@wendyamoni-creator Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@wendyamoni-creator is attempting to deploy a commit to the icentedward76-sketch's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #255.
The check-in deadline formula (
lastCheckin + checkinPeriodDays × 86 400 × 1000) existed in three places:src/lib/deadlines.tssrc/lib/certificate.tsnextCheckinDeadline— no change neededsrc/lib/reminders.tsbuildDeadline()— removedChanges
src/lib/reminders.tsimport { nextCheckinDeadline } from '@/lib/deadlines'buildDeadlinefunctionnextCheckinDeadline(will)tests/unit/certificate.test.ts(new)Next check-in due:PDF line matchesnextCheckinDeadline's output for the sameWillfixturelastCheckin/checkinPeriodDaysmatches the shared helperVerification
No errors from
tsc --noEmitin any modified file. Thepackage-lock.jsonis intentionally excluded from this commit (it changed only becausenode_moduleswas missing in the dev container). closes #255