Skip to content

fix: make WalletConnectButton connected state interactive - #516

Merged
Just-Bamford merged 2 commits into
Sorokit:mainfrom
Sammygee12:fix/issue-438-walletconnectbutton-connected-state-is-a-dead
Sep 1, 2026
Merged

fix: make WalletConnectButton connected state interactive#516
Just-Bamford merged 2 commits into
Sorokit:mainfrom
Sammygee12:fix/issue-438-walletconnectbutton-connected-state-is-a-dead

Conversation

@Sammygee12

Copy link
Copy Markdown
Contributor

Overview

This PR fixes the dead interactive element in WalletConnectButton's connected state by replacing the no-op <button> with a Radix UI DropdownMenu. The connected wallet display now opens a menu with Copy Address, View on Explorer, and Disconnect actions, and the unused onOpenModal prop has been removed.

Related Issue

Changes

🎛️ Connected-Wallet Dropdown Menu

  • [MODIFY] src/components/WalletConnectButton.tsx

    • Replaced the connected-state <button> with a Radix UI DropdownMenu trigger, keeping the truncated-address + green-dot visual and adding a chevron affordance.
    • Added Copy Address — copies the full connected public key to the clipboard with temporary "Copied!" feedback.
    • Added View on Explorer — opens the connected account in a new tab on the Stellar explorer.
    • Added Disconnect — clears the wallet connection and returns the user to ConnectScreen.
    • [REMOVE] Unused onOpenModal optional prop and its no-op onClick handler — no caller in the codebase ever passed it.
  • [ADD] src/components/__tests__/WalletConnectButton.test.tsx

    • Coverage for dropdown rendering, copy-address behaviour, explorer link, disconnect flow, and absence of onOpenModal.

Verification Results

npm test -- src/components/__tests__/WalletConnectButton.test.tsx
✅ 4/4 passed

Manual acceptance check:
✅ Clicking connected wallet opens dropdown with 3 visible actions
✅ Copy Address places full public key on clipboard
✅ View on Explorer opens account in new tab
✅ Disconnect clears connection and returns to ConnectScreen
✅ onOpenModal prop removed — zero remaining references
Acceptance Criteria Status
Clicking the connected wallet display produces a visible, useful result ✅ Dropdown menu opens with Copy Address, View on Explorer, and Disconnect
Connected address can be copied from the header area ✅ Copy Address copies the full public key to the clipboard
Disconnecting from the header area works and returns user to ConnectScreen ✅ Disconnect clears state and routes back to ConnectScreen
onOpenModal is either removed or has at least one caller ✅ Prop removed; no references remain in the codebase

Closes #438

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@Sammygee12 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Just-Bamford
Just-Bamford merged commit 2fe5de9 into Sorokit:main Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WalletConnectButton connected state is a dead interactive element

2 participants