Skip to content

fix: add typecheck and validate scripts to package.json for CI and local validation - #627

Merged
k-deejah merged 1 commit into
Sorokit:mainfrom
sojetunde8:fix/issue-567
Aug 29, 2026
Merged

fix: add typecheck and validate scripts to package.json for CI and local validation#627
k-deejah merged 1 commit into
Sorokit:mainfrom
sojetunde8:fix/issue-567

Conversation

@sojetunde8

Copy link
Copy Markdown
Contributor

Closes #567

Summary

  • Updated typecheck, typecheck:watch, and type-check scripts in package.json to use tsc -b --noEmit (project references mode), matching the root tsconfig.json which uses "references" array
  • Added a combined validate script (npm run typecheck && npm run lint) for fast local preflight checks before pushing
  • Updated .github/workflows/test.yml to run npm run validate instead of separate lint and typecheck steps, reducing CI step count while keeping the same coverage

Scope

Does not fix existing type errors surfaced by the typecheck (e.g. _params: any cast in main.tsx, loose status: string in client interfaces). Those are pre-existing and out of scope for this issue.

Testing

  • Verified the diff is minimal (2 files changed, 6 insertions, 8 deletions)
  • npm run typecheck runs tsc -b --noEmit and correctly uses project references
  • npm run validate runs typecheck then lint in sequence
  • CI workflow updated to use the single validate command

Files changed

  • package.json — Added -b flag to typecheck scripts for project references; added validate script
  • .github/workflows/test.yml — Consolidated lint + typecheck steps into single validate step

…cal validation

- Update typecheck scripts to use `tsc -b --noEmit` for project references
- Add combined `validate` script (typecheck + lint) for fast local preflight
- Update test.yml CI workflow to run `npm run validate` instead of separate lint/typecheck steps
@drips-wave

drips-wave Bot commented Aug 29, 2026

Copy link
Copy Markdown

@sojetunde8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@k-deejah
k-deejah merged commit f7fd34a into Sorokit:main Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add typecheck and lint scripts to package.json for CI and local validation

2 participants