fix: add typecheck and validate scripts to package.json for CI and local validation - #627
Merged
Merged
Conversation
…cal validation - Update typecheck scripts to use `tsc -b --noEmit` for project references - Add combined `validate` script (typecheck + lint) for fast local preflight - Update test.yml CI workflow to run `npm run validate` instead of separate lint/typecheck steps
|
@sojetunde8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #567
Summary
typecheck,typecheck:watch, andtype-checkscripts inpackage.jsonto usetsc -b --noEmit(project references mode), matching the roottsconfig.jsonwhich uses"references"arrayvalidatescript (npm run typecheck && npm run lint) for fast local preflight checks before pushing.github/workflows/test.ymlto runnpm run validateinstead of separate lint and typecheck steps, reducing CI step count while keeping the same coverageScope
Does not fix existing type errors surfaced by the typecheck (e.g.
_params: anycast inmain.tsx, loosestatus: stringin client interfaces). Those are pre-existing and out of scope for this issue.Testing
npm run typecheckrunstsc -b --noEmitand correctly uses project referencesnpm run validateruns typecheck then lint in sequencevalidatecommandFiles changed
package.json— Added-bflag to typecheck scripts for project references; addedvalidatescript.github/workflows/test.yml— Consolidated lint + typecheck steps into singlevalidatestep