UI: Extract Trace Logger custom format tooltip strings into resources file for localization#61
Open
icefairy64 wants to merge 1 commit into
Conversation
Yave-Yu
pushed a commit
to Yave-Yu/MesenYY
that referenced
this pull request
May 2, 2026
Heemin wanted to make a homebrew for Namco's 163 without needing a battery, but Mesen was handling cart RAM banks incorrectly (all four 2KiB windows were the first 2KiB of the 8KiB of cart ram, regardless of amount specified in the header) The added line fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking through the source code I have noticed a few hardcoded English strings and decided to take a shot at extracting them into the resource file to allow for proper localization.
Initially I wanted to introduce a new complex resource tag along the lines of
Tooltip/Multilinefor this, but I have no idea what the best approach to separate tooltip structure and localizable strings would be in that case, so I decided against it for now.Not quite sure if the proposed approach is appropriate - happy to hear any feedback on this!