Snes: Fix integer overflow for calculating dma overhead#87
Open
denniskempin wants to merge 1 commit into
Open
Conversation
RunDma will transfer up to 2^16 bytes, this will overflow the uint8_t counter. This has no practical implications other than SyncEndDma not calculating the right amount of cycles to add. I am not aware of this behavior causing any issues in games.
This was referenced Mar 1, 2026
Mokona
pushed a commit
to Mokona/MesenCE
that referenced
this pull request
May 17, 2026
* GbNoiseChannel.cpp remove cp1252 * GbSquareChannel.cpp remove cp1252 * GbWaveChannel.cpp remove cp1252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunDma will transfer up to 2^16 bytes, this will overflow the uint8_t counter. This overflow has no practical implications other than SyncEndDma not calculating the right amount of cycles to add.
I am not aware of this behavior causing any issues in games.