Remove dead try_map_match_arms and align comments with actual TryFrom conversion #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the unused try_map_match_arms vector and its population from cli_parser.rs and updates comments to reflect the actual conversion path implemented in the macro. The codebase performs conversions at the RuntimeSubcommand<__Inner> -> RuntimeMessage<__Dest> stage via TryFrom and does not implement TryFrom<RuntimeMessage<__Inner>> for RuntimeMessage<__Dest>, making try_map_match_arms dead code. Eliminating it reduces unnecessary allocations during code generation and avoids confusion for maintainers by keeping comments consistent with the implementation, without altering runtime behavior.