Add some logging to warp metric collection #2244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| tracing::trace!( | ||
| route_count = route_ids.len(), | ||
| "Emitting rate limiter metrics at slot {}", |
Member
There was a problem hiding this comment.
String interpolation will blow up structured loggin, such as loki
Member
Author
There was a problem hiding this comment.
should I use format! instead?
Member
There was a problem hiding this comment.
Because it will index body, so instead having single searchable body "Emitting rate limiter metrics" it will have it at which slot, which is increasing.
I would suggest to use it as attribute, same way we have route_count
Member
Author
There was a problem hiding this comment.
The body will be searchable with Emitting rate limiter metrics.*
It's a high cardinality field, is it OK to add it as an attribute?
Member
There was a problem hiding this comment.
It's a high cardinality field, is it OK to add it as an attribute?
Yep, that's the idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the changes...
CHANGELOG.mdwith a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.Cargo.tomlchanges before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?
Rendered docs are available at
https://sovlabs-ci-rustdoc-artifacts.us-east-1.amazonaws.com/<BRANCH_NAME>/index.html