M12.8 (server): config_source= on gitway diag line (NFR-24)#3
Merged
Conversation
Adds diagnostic::emit_for_with_config_sources(&AnvilError, &[PathBuf]) entry point. Emits the standard gitway diag line plus an additional config_source=path1,path2 field listing the ssh_config(5) files that were consulted during the failing invocation. An empty slice produces output identical to emit_for, so the new entry point is a strict superset. The Gitway CLI consumes this in a follow-up PR (M12.8 client side): gitway-cli/src/main.rs computes the deduplicated path list before calling run() and passes it to emit_for_with_config_sources at the existing emit_for(e) call site. Cargo.toml: 0.3.0 -> 0.3.1 (additive, no breaking changes). CHANGELOG: 0.3.1 entry. Plan: M12.8 of let-us-plan-on-bright-cosmos.md (Anvil server side).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
M12.8 server-side wiring for NFR-24: adds
diagnostic::emit_for_with_config_sources(&AnvilError, &[PathBuf]), which emits the standardgitway diagline plus aconfig_source=path1,path2field listing thessh_config(5)files that were consulted during the failing invocation.An empty
&[]reproduces the existingemit_foroutput exactly, so the new entry point is a strict superset. Existingemitandemit_forcontinue to work unchanged.This is the server side of M12.8. The Gitway-side consumer (computing the deduplicated path list before
run()and passing it to the new entry point) lands as a separate PR againstSteelbore/Gitwayonceanvil-ssh 0.3.1is published.Versioning
Bumps
anvil-ssh0.3.0 → 0.3.1. Pure addition — no breaking changes — so a patch bump is appropriate. Cargo's^0.3.0semver requirement will pull 0.3.1 automatically.Test plan
cargo fmt --all -- --checkclean.cargo clippy --all-targets --all-features -- -D warningsclean.cargo test --lib --tests --lockedgreen on all platforms (153 lib tests).v0.3.1, publish to crates.io.🤖 Generated with Claude Code