feat(nickel): emit services block from probed inventory#62
Merged
Conversation
Continues M4 W1 reconcile (Plan §7.5). The services block is the last per-subsystem table that maps cleanly from the probed inventory. Emits enabled/disabled/masked Vec<String> from the ServiceInventory's BTreeSet members; the active set is dropped since it represents runtime drift, not declaration. Empty-block emission when probe.services is None — keeps the schema's #[serde(default)] entry points consistent with what the imported file declares. Per the module-level doc, the emitter does NOT try to filter "noisy" defaults out of services.enabled — guessing wrong silently drops state that ought to be declared. Operator review of the imported.ncl is the curation step; reconcile is just providing a starting draft. Three new unit tests: - enabled/disabled/masked arrays in sorted order - empty inventory case (no probed services) → empty arrays - service block appears AFTER packages for stable golden-fixture diffs Tests: 327 passing (+3). Clippy clean. fmt clean. audit clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues M4 W1 reconcile (Plan §7.5). The services block is the last per-subsystem table that maps cleanly from the probed inventory. Emits
enabled/disabled/maskedVec<String>from theServiceInventory'sBTreeSetmembers; theactiveset is dropped since it represents runtime drift, not declaration.Empty-block emission when
probe.servicesisNone— keeps the schema's#[serde(default)]entry points consistent with what the imported file declares.Per the module-level doc, the emitter does NOT try to filter "noisy" defaults out of
services.enabled— guessing wrong silently drops state that ought to be declared. Operator review of the imported.ncl is the curation step; reconcile is just providing a starting draft.Three new unit tests:
Test plan
cargo test --workspace --all-features— 327 passing (+3 new)cargo clippy --workspace --all-targets --all-features -- -D warnings— cleancargo fmt --all -- --check— cleanscripts/ci/check-spdx.sh— cleanpearlite-audit check .— 1 check, 0 violations🤖 Generated with Claude Code