feat(vault-tui): About overlay (Standard §13.2)#18
Merged
Conversation
Add a read-only About screen (open with `?` or `:about`, dismiss with Esc/q/Enter) showing the version, maintainer, copyright/license, and canonical URL — rendered from the same ATTRIBUTION / PKG_VERSION constants as `vault-tui --version`, so it can't drift. Fulfills the last unfilled v0.1 success criterion that the §13.2 block appears in --version, --help, README, and the TUI About screen (PRD §14). - app.rs: InputMode::About + open_about/close_about (const). - main.rs: ? key + :about command + handle_about_key + dispatch; ATTRIBUTION / PKG_VERSION made pub(crate). - ui.rs: render_about (modeled on render_generator) + the wired match arms. - Tests: app open/close; a TestBackend render test asserting the §13.2 content (version / maintainer / license / URL) reaches the screen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a read-only About overlay to
vault-tui— open with?or:about,dismiss with
Esc/q/Enter— showing the version, maintainer,copyright/license, and canonical URL.
This fulfills the last unfilled v0.1 success criterion: the Standard §13.2
attribution block must appear "in
--version,--help, README, and the TUIAbout screen" (PRD §14). The first three already existed; this is the fourth.
How
app.rs: new statelessInputMode::About+open_about/close_about(modeled on the generator overlay's open/close).
main.rs:?key (+:aboutcommand) →open_about;handle_about_keydismisses on
Esc/q/?/Enter.ATTRIBUTION/PKG_VERSIONmadepub(crate)so the overlay renders from the same source asvault-tui --version— no drift.ui.rs:render_about(centered,Cleared, bordered box — same shape asrender_generator), wired through the render + status-bar match arms.Tests
app.rs:open_about/close_aboutflipInputModecorrectly.ui.rsTestBackend:about_overlay_renders_attributionasserts the §13.2content (version /
Mohamed Hammad/GPL-3.0-or-later/SpacecraftSoftware.org) actually reaches the screen.Local CI-exact gates all green:
fmt, fresh isolatedclippy -D warnings,cargo test --workspace --all-targetsunderRUSTFLAGS=-D warnings,cargo deny check(no new deps), both headless builds.🤖 Generated with Claude Code