feat(vault-tui): card/identity detail render (+ reveal/copy)#24
Merged
Conversation
Complete card/identity support in the TUI. Selecting a card/identity fetches its non-sensitive fields on-select via the existing Request::Get and renders them in the detail pane; the card number/CVV stay masked and the number is fetched only on reveal (Space) — like passwords, so no card secret enters the TUI until asked. - app.rs: DetailView + App.detail cache; primary_secret_field / primary_copy_field (type-aware Space/c). - main.rs: ensure_detail (fetch on select, cached per id) in the run loop; toggle_reveal + the `c` key now use the per-type primary field. - ui.rs: render_detail branches for card (brand/exp + masked number/CVV) and identity (name/email/phone/address). No proto/agent/core change (reuses the PR #23 Field selectors). Card/identity is now end-to-end (CLI + TUI). Tests: primary_*_field units; TestBackend renders for card (masked + revealed number) and identity contact fields. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes card/identity support in the TUI (CLI landed in PR #23). Selecting a
card or identity now shows its fields in the detail pane:
Spacereveals it, re-maskedon navigation away), and a masked CVV.
ccopies the primary field per type — card → number, identity → email(login → password, unchanged);
Spacereveals the primary secret (cardnumber / login password).
Security stays consistent with logins: the non-sensitive fields are fetched on
select, but the card number/CVV are fetched only on reveal — no card secret
enters the TUI process until you ask.
How
No proto/agent/core change — reuses the PR #23
Fieldselectors +Request::Get.app.rs:DetailView+App.detail(per-id cache of the fetchednon-sensitive fields); pure
primary_secret_field/primary_copy_field(type → field) driving
Space/c.main.rs:ensure_detail(run-loop, before draw; fetches on selectionchange, cheap no-op otherwise) + a
fetch_fieldhelper that skipsNoSuchField;toggle_revealand thecbinding made type-aware.ui.rs:render_detailbranches for card / identity (login unchanged).Tests
app.rs:primary_secret_field/primary_copy_fieldper cipher type.ui.rsTestBackend: card detail shows brand/expiry + masked number (rawnumber absent until a
RevealedSecretis set, then present) + masked CVV;identity shows email/phone.
Local CI-exact gates all green:
fmt, fresh isolatedclippy -D warnings,cargo test --workspace --all-targetsunderRUSTFLAGS=-D warnings,cargo deny check(no new deps), both headless builds.🤖 Generated with Claude Code