feat(vault-tui): create/edit identities in the add/edit form (curated)#28
Merged
Conversation
The TUI `a`/`e` form now composes identity (type 4) ciphers — the Type row cycles login → secure note → card → identity. No backend change: it builds the `IdentityWrite` payload that already rides Request::Add/Edit (CLI write path, PR #27). To fit the non-scrolling overlay the form edits a curated 10-field subset (title, first/last name, email, phone, address1, city, state, postal, country); the long-tail fields and the SSN/passport/license secrets stay CLI-only. - app.rs: F_TITLE..F_COUNTRY rows; visible_fields/blank_fields grow the identity subset; toggle_type cycles through type 4; type_label "identity"; new FormSubmit.identity (IdentityFields, all non-secret); submit() takes the curated fields and folds them into the edit "no changes" gate; new_edit prefills email/phone from the detail pane (Person/Address are composites that can't be split back, so the rest start blank). - main.rs: submit_form builds IdentityWrite when the type is identity and threads it into both Add and Edit. - Tests: identity add carries the curated fields, identity edit prefill/diff; updated the type-toggle test for the 4-way cycle. - docs: README TUI note, CHANGELOG entry. All four cipher types are now editable from both front-ends. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The TUI's
a/eform now creates and edits identity (type 4) ciphers — the Type row cycleslogin → secure note → card → identity. With this, all four cipher types are editable from both front-ends (CLI + TUI).No backend change — it builds the
IdentityWritepayload that already ridesRequest::Add/Edit(PR #27).Scope: curated, no scroll
The form overlay (
render_form) renders all rows into one non-scrollingParagraph. Identity's full 18 fields would overflow it, so the form edits a curated 10-field subset (title, first/last name, email, phone, address1, city, state, postal code, country). The long-tail fields (middle name, identity-username, company, address2/3) and the three secrets (SSN/passport/license) stay CLI-only.How (
crates/vault-tui/only)app.rs—F_TITLE..F_COUNTRYrows;visible_fields/blank_fieldsgrow the identity subset;toggle_typecycles through type 4;type_label→"identity". NewFormSubmit.identity(IdentityFields, all non-secret).submit()takes the curated fields and folds them into the edit "no changes" gate.new_editprefills email/phone from the detail pane — the pane'sPerson/Addressare composites that can't be split back, so the rest start blank = leave-unchanged.main.rs—submit_formbuildsIdentityWritewhen the type is identity and threads it into bothRequest::AddandRequest::Edit.Tests
type_toggle_swaps_visible_fields_preserving_valuesfor the 4-way cyclecargo fmt --check, fresh-isolatedclippy -D warnings,cargo test --workspace --all-targets(71 TUI tests),cargo deny check, and both headless builds all clean.Out of scope (tracked follow-ups)
Field::CardCardholderread selector; per-field TUI reveal/copy for long-tail fields + card CVV.🤖 Generated with Claude Code