feat(vault): granular identity field selectors (CLI + TUI per-field)#36
Merged
Conversation
Adds 16 per-field identity `Field` selectors alongside the composed
identity-name / identity-address, so every identity field is individually
readable and the TUI per-field reveal/copy reaches all of them.
- vault-ipc: 16 `Field` variants (IdentityTitle…IdentityCountry;
ssn/passport/license sensitive).
- vault-agent: `get_item` decrypts the identity and returns each field
(one value arm apiece); the 16 join the identity DecryptOptions group.
- vault-cli: `FieldArg` + From map → `--field identity-{title,first-name,
middle-name,last-name,username,company,ssn,passport,license,address1,
address2,address3,city,state,postal,country}`.
- vault-tui: identity `detail_fields` is now the full granular set
(ssn/passport/license masked, revealed on demand like the card CVV);
`ensure_detail` fetches the non-sensitive ones on select. The detail
field cursor (PR #35) reveals/copies each.
- docs: README selector list, CHANGELOG.
Same proto → agent → CLI → TUI shape as the card-* selectors. Detail-pane
scrolling for the ~18-row identity detail is a tracked follow-up.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 16 granular identity
Fieldselectors alongside the composedidentity-name/identity-address, so every identity field is individually readable on the CLI and the TUI per-field reveal/copy (PR #35) reaches all of them — including the sensitive SSN/passport/license (masked, revealed on demand like the card CVV). This was the last tracked code follow-up.New selectors:
identity-{title, first-name, middle-name, last-name, username, company, ssn, passport, license, address1, address2, address3, city, state, postal, country}.How (same shape as the
card-*selectors)Fieldvariants (IdentityTitle … IdentityCountry).get_itemadds the 16 to the identityDecryptOptions { identity: true }group + one value arm each (directPlainIdentityfield clones; ssn/passport/license return plaintext likecard-code).FieldArg+ theFrom<FieldArg> for Fieldmap (clap derives theidentity-*kebab names).detail_fieldsis now the full granular set (ssn/passport/licensemasked);ensure_detailfetches the non-sensitive ones on select. The existing detail field cursor reveals/copies each.Tests
detail_fields(4)returns the 18-field granular set with the three sensitive fields masked and mapped to the rightFields; existing identity decrypt/render tests still pass. The proto/CLI mapping is compiler-exhaustive.Verification
fmt --check, fresh-isolatedclippy --all-features -D warnings,cargo test --workspace --all-targets,cargo deny check, both headless builds — all green.Manual:
vault get "Jane Doe" --field identity-ssn/--field identity-companyreturn the values; in the TUI,Tabto the identity detail,j/ktoSSN,Spacereveals,ccopies.Out of scope (tracked follow-up)
Detail-pane scrolling — the identity detail is now ~18 rows and can clip on a very short terminal (the cursor still reveals/copies clipped rows). A small viewport follow-up reusing
scroll_offset.🤖 Generated with Claude Code