Skip to content

chore(deps): upgrade eslint and fix react hooks lint#70

Merged
jumalaw98 merged 1 commit into
devfrom
chore/deps-eslint-10-react-hooks-cleanup
May 6, 2026
Merged

chore(deps): upgrade eslint and fix react hooks lint#70
jumalaw98 merged 1 commit into
devfrom
chore/deps-eslint-10-react-hooks-cleanup

Conversation

@jumalaw98

@jumalaw98 jumalaw98 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Upgrade ESLint-related tooling and clean up React hook lint violations introduced by the stricter rules.


🏷️ Type of Change

  • feature (minor release)
  • bug (patch release)
  • breaking (major release)
  • enhancement
  • refactor
  • docs
  • ci

🌍 Scope

  • frontend
  • backend
  • ui/ux

🔗 Related Issues

Closes #


📸 Screenshots

Not applicable; this is lint/tooling cleanup with no intended UI changes.


🧪 Testing

  • Verified formatting, lint, type-check, and production build locally.

  • Tested locally

  • Tested on desktop

  • Tested on mobile


✅ Checklist

  • PR is linked to an issue
  • Branch is up to date with main
  • Build passes (npm run build)
  • Lint passes (npm run lint)
  • No sensitive data (tokens, secrets)
  • Follows project conventions
  • UI is responsive (if applicable)
  • Accessibility considered (semantic HTML, alt text, keyboard nav)

⚠️ Breaking Changes

None.


📝 Notes for Reviewers

This PR updates Dependabot grouping so ESLint, @typescript-eslint/*, and related flat-config dependencies move together. Most source changes address stricter React hook lint rules without changing intended behavior.


Summary by cubic

Upgraded ESLint to v10 and eslint-plugin-react-hooks to v7, then refactored frontend code to satisfy stricter React Hooks rules without changing behavior.

  • Dependencies

    • Bump eslint to ^10.3.0 and eslint-plugin-react-hooks to ^7.1.1.
    • Adjust Dependabot groups so @typescript-eslint/*, eslint*, @eslint/*, globals, and Prettier move together.
    • Note: ESLint 10 requires Node >= 20.19.0 for local dev.
  • Refactors

    • Wrap state updates in effects with async IIFEs; add cancellation guards for async fetches.
    • Use lazy initial state (e.g., localStorage, window size) to avoid side effects in render.
    • Move impure calls (Date.now, Math.random) to module scope; use stable hashes for demo data.
    • Minor cleanups: safer prop typing with Readonly<>, extracted helpers, and small UI conditionals rewritten for clarity.
    • No UI or runtime behavior changes intended.

Written for commit 6c35058. Summary will update on new commits.

@vercel

vercel Bot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sytcolabs Ready Ready Preview, Comment May 5, 2026 7:31am

@github-actions github-actions Bot added the chore label May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

Changelog preview

This is what the changelog entry will look like once this PR is merged.

No conventional commits found in this PR.

@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedeslint@​9.39.4 ⏵ 10.3.089 +110010097100
Updatedeslint-plugin-react-hooks@​5.2.0 ⏵ 7.1.1100 +310010096100

View full report

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 27 files

@jumalaw98 jumalaw98 merged commit b03fad6 into dev May 6, 2026
30 of 35 checks passed
@jumalaw98 jumalaw98 deleted the chore/deps-eslint-10-react-hooks-cleanup branch May 6, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant