Fixes xml:base and default namespace declarations#9
Merged
mjy merged 1 commit intoSpeciesFileGroup:masterfrom Dec 12, 2018
hlapp:patch-3
Merged
Fixes xml:base and default namespace declarations#9mjy merged 1 commit intoSpeciesFileGroup:masterfrom hlapp:patch-3
mjy merged 1 commit intoSpeciesFileGroup:masterfrom
hlapp:patch-3
Conversation
The fact that these have presumably been left at initial (Protégé-suggested?) default settings happens to be inconsequential in the current version of the document, because all IRIs are given as absolute ones, and all XML elements use an explicit namespace, including the ones from this ontology. That said, arguably they should be set to meaningful values, so that if in the future an ontology editor were to use a relative URI or a term from this ontology without namespace, then the presumably "correct thing" would happen. For example, setting the default namespace (`xmlns`) correctly means you can write ```xml <NOMEN_0000001>1960</NOMEN_0000001> ``` instead of ``` <obo:NOMEN_0000001>1960</obo:NOMEN_0000001> ``` and they would both result in the exact same axiom. The other advantage is this change would eliminate a source of confusion as to what the namespace of this ontology is, see for example pensoft/OpenBiodiv#44.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fact that these have presumably been left at initial (Protégé-suggested?) default settings happens to be inconsequential in the current version of the document, because all IRIs are given as absolute ones, and all XML elements use an explicit namespace, including the ones from this ontology.
That said, arguably they should be set to meaningful values, so that if in the future an ontology editor were to use a relative URI or a term from this ontology without namespace, then the presumably "correct thing" would happen. For example, setting the default namespace (
xmlns) correctly means you can writeinstead of
and they would both result in the exact same axiom.
The other advantage is this change would eliminate a source of confusion as to what the namespace of this ontology is, see for example pensoft/OpenBiodiv#44.