Skip to content

Placer order#609

Draft
Christian-B wants to merge 13 commits intomasterfrom
placer_order
Draft

Placer order#609
Christian-B wants to merge 13 commits intomasterfrom
placer_order

Conversation

@Christian-B
Copy link
Member

@Christian-B Christian-B commented Jul 29, 2025

Work to allow the normal placer to happen before the monitors are added.

ApplicationPlacer changes

  1. removed _cap_sdram was unneeded and weird as it double counted monitor
  2. No longer returns the Placements object just uses it
  3. _space_on_chip adds monitor costs to check the chip has space

tests changed as ApplicationPlacer no longer returns

@Christian-B
Copy link
Member Author

todo:
rename "system_placement" to just "placements

check ApplicationPlacer._place_error

  • does it think there are tow different Placement objects . (there no longer are)

@Christian-B Christian-B marked this pull request as draft July 29, 2025 11:04
@Christian-B
Copy link
Member Author

It appears that ApplicationPlacer._place_error compares the previous placements with the current placements.
However for speed master no longer clones the placements so this does not amke sense.

Options are.

  1. Leave the code as in with a log that the code should eb changed if needed.
  2. Clone the previous placements
  • always (previous will now often be empty_
  1. Clone the previous on a cfg setting for example Mode = debug
  2. Strip that compare code out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant