Add PlayerConfigurationEvent

[Outfluencer]

I have tested this on latest, also tested switching servers.

Tested with this sample plugin

import net.md_5.bungee.api.chat.TextComponent;
import net.md_5.bungee.api.connection.ProxiedPlayer;
import net.md_5.bungee.api.dialog.DialogBase;
import net.md_5.bungee.api.dialog.NoticeDialog;
import net.md_5.bungee.api.dialog.action.ActionButton;
import net.md_5.bungee.api.dialog.action.CustomClickAction;
import net.md_5.bungee.api.event.CustomClickEvent;
import net.md_5.bungee.api.event.PlayerConfigurationEvent;
import net.md_5.bungee.api.event.PlayerDisconnectEvent;
import net.md_5.bungee.api.plugin.Listener;
import net.md_5.bungee.api.plugin.Plugin;
import net.md_5.bungee.event.EventHandler;

import java.util.Collections;
import java.util.HashMap;
import java.util.Map;

public class Main extends Plugin implements Listener {

    @Override
    public void onEnable() {
        getProxy().getPluginManager().registerListener(this, this);
    }

    private Map<ProxiedPlayer, PlayerConfigurationEvent> awaitingPlayers = Collections.synchronizedMap(new HashMap<>());

    @EventHandler
    public void onConfig(PlayerConfigurationEvent event) {
        event.registerIntent(this);
        event.getPlayer().showDialog(new NoticeDialog(new DialogBase(new TextComponent("HALLO!!")), new ActionButton(new TextComponent("test"), new CustomClickAction("bert:bert"))));
        awaitingPlayers.put(event.getPlayer(), event);
    }

    @EventHandler
    public void onDialog(CustomClickEvent event) {
        PlayerConfigurationEvent configEvent = awaitingPlayers.get(event.getPlayer());
        if (configEvent != null) {
            configEvent.completeIntent(this);
            event.getPlayer().sendMessage(new TextComponent("You clicked!"));
        }
    }

    @EventHandler
    public void onDisconnect(PlayerDisconnectEvent event) {
        awaitingPlayers.remove(event.getPlayer());
    }
}

[Outfluencer]

Closes #3869

[Outfluencer]

I have tested this heavily now on 1.21.8, joining, switching servers & backend reconfigiring works all perfectly fine.

Also slightly tested the other versions, and encounter no problems

[Outfluencer]

@md-5 what do you think about this impl?

[md-5]

Let's look after 1.21.9. I'm worried about making the configuration phase even more complicated

[Outfluencer]

time to take a look @md-5?

[md-5]

Can't you just .retain the original?

[Outfluencer]

yes, but we have to release them if the connection unexpectedly closes then

[md-5]

An unpooled buffer can leak too

[Outfluencer]

I thought unpooled heap buffers are always just garbage collected without any problems, anyways i habe changed it to retain the buffer and release them in the channels close future

[md-5]

Shouldn't we handle those multiple packets then?

[Outfluencer]

i'd say no, if we would calll ServerConnector.handleLogin again it would break api and call ServerConnected Event multiple times for the server just because its reconfiguring. also it would clear scoreboards and tablist then, even if the client has not really switched the server

[Outfluencer]

Also as fas as i know vanilla/datapacks do not reconfigure the client and spigot has no api for it, to reconfigure the client you would have to use nms or paper api

[md-5]

Shouldn't we disconnect then? The server is doing something and we're just ignoring it

[Outfluencer]

But why, the backend reconfiguring the client shouldn’t break anything. We can just let it happen.

I am not sure what specificly should we handle in this case

[md-5]

The backend is sending a packet and we're just blocking it from doing anything

[Outfluencer]

why are we blocking it if its not the first packet it does not throw CancelSendSignal

the packet just goes through or not?