Let MetricsView accept metrics which have some nans
#217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Another cool feature would be to add Mouse selection on the metrics view! Maybe we could do it in the same PR? |
Member
Author
|
So you click on one of the off-diagonal plots, it finds the closest point on the metric scatter, then it selects from the unit that that point came from? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if one unit has a
nanvalue, the metics distribution cannot be plotted inMetricsView. This PR fixes this!If the units' metrics' value is
nan, no dot is plotted on the diagonal plot, and no line is plotted on the off-diagonal plots which involve this unit.Also delted some stuff that's not used in
MetricsPlotooops not done panel