Fix PCA metric recomputation when "soft" merging - #4748
Open
RobertoDF wants to merge 2 commits into
Open
Conversation
Use every analyzer unit as PCA comparison context when recomputing metrics only for newly merged or split units. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soft merges and splits recompute quality metrics only for newly created units. Previously, this subset was also used as the complete PCA comparison population. Consequently, merged units could not see neighboring unchanged units, producing incorrect "No other units found" warnings and invalid or fallback PCA metrics.
Keep the recomputation targets limited to new units, but use all analyzer units
for PCA projections, neighbor selection, spike counts, and firing rates.
Done with help from copilot, seems reasonable, results seems fine