Modify define_function_handling_dict_from_class to inject function to module directly - #4752
Open
alejoe91 wants to merge 1 commit into
Open
Modify define_function_handling_dict_from_class to inject function to module directly#4752alejoe91 wants to merge 1 commit into
define_function_handling_dict_from_class to inject function to module directly#4752alejoe91 wants to merge 1 commit into
Conversation
…ion to module directly
alejoe91
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having something like:
extends the function to work with individual recordings and dicts of. The function signature and name are set to match the class and provided
name. This could cause mismatches in the naming.This PR uses a trick to add the new wrapped function directly to the caller module.
Related to #4319 : I suggest we do the same for
define_funtction_from_class(already 2 mismatches found!!!) and use thepyiapproach that Graham suggested to make IDEs happy.@chrishalcrow @grahamfindlay thoughts?